* [PATCH 1/1] ibmveth: Fix oops on request_irq failure
@ 2011-09-28 15:33 Brian King
2011-09-29 4:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Brian King @ 2011-09-28 15:33 UTC (permalink / raw)
To: netdev; +Cc: brking
If request_irq fails, the ibmveth driver will overwrite
the rc and end up returning a successful rc on its open
function, resulting in an oops later when a packet gets
sent and buffers are not allocated due to the failed open.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/net/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/net/ibmveth.c~ibmveth_bounce_oops2 drivers/net/ibmveth.c
--- linux-2.6/drivers/net/ibmveth.c~ibmveth_bounce_oops2 2011-09-28 09:53:09.000000000 -0500
+++ linux-2.6-bjking1/drivers/net/ibmveth.c 2011-09-28 09:53:09.000000000 -0500
@@ -636,8 +636,8 @@ static int ibmveth_open(struct net_devic
netdev_err(netdev, "unable to request irq 0x%x, rc %d\n",
netdev->irq, rc);
do {
- rc = h_free_logical_lan(adapter->vdev->unit_address);
- } while (H_IS_LONG_BUSY(rc) || (rc == H_BUSY));
+ lpar_rc = h_free_logical_lan(adapter->vdev->unit_address);
+ } while (H_IS_LONG_BUSY(lpar_rc) || (lpar_rc == H_BUSY));
goto err_out;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ibmveth: Fix oops on request_irq failure
2011-09-28 15:33 [PATCH 1/1] ibmveth: Fix oops on request_irq failure Brian King
@ 2011-09-29 4:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-09-29 4:34 UTC (permalink / raw)
To: brking; +Cc: netdev
From: Brian King <brking@linux.vnet.ibm.com>
Date: Wed, 28 Sep 2011 10:33:43 -0500
>
> If request_irq fails, the ibmveth driver will overwrite
> the rc and end up returning a successful rc on its open
> function, resulting in an oops later when a packet gets
> sent and buffers are not allocated due to the failed open.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-29 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-28 15:33 [PATCH 1/1] ibmveth: Fix oops on request_irq failure Brian King
2011-09-29 4:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).