netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: netdev@vger.kernel.org, stable@kernel.org, nautsch@gmail.com
Subject: Re: [PATCH net/stable] can bcm: fix tx_setup off-by-one errors
Date: Thu, 29 Sep 2011 03:58:09 -0400 (EDT)	[thread overview]
Message-ID: <20110929.035809.1014076114218537552.davem@davemloft.net> (raw)
In-Reply-To: <4E842266.9090407@hartkopp.net>

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Thu, 29 Sep 2011 09:46:46 +0200

> when backporting the patch to an older kernel we discovered a problem this
> patch is introducing - which causes a new regression :-(
> 
> Could you please revert this patch and dequeue it from stable?

It's already pushed out to the net GIT tree, I can't delete history so
now the only thing I can do is add a butt-ugly revert commit this late
in the -rcX which is terrible.

This patch was sitting out there for review for 6 days, which should
have been more than enough time to audit it for problems.

  reply	other threads:[~2011-09-29  8:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 18:23 [PATCH net/stable] can bcm: fix tx_setup off-by-one errors Oliver Hartkopp
2011-09-27 21:09 ` Andre Naujoks
2011-09-29  4:33 ` David Miller
2011-09-29  7:46   ` Oliver Hartkopp
2011-09-29  7:58     ` David Miller [this message]
2011-09-29  8:04       ` Oliver Hartkopp
2011-09-29  8:24         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110929.035809.1014076114218537552.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=nautsch@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).