From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Van Dijck Subject: Re: [PATCH net-next v2] candev: allow SJW user setting for bittiming calculation Date: Thu, 29 Sep 2011 08:14:02 +0200 Message-ID: <20110929061402.GA322@e-circ.dyndns.org> References: <4E7B0DE6.9020807@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: SocketCAN Core Mailing List , Linux Netdev List , David Miller , Wolfgang Grandegger To: Oliver Hartkopp Return-path: Content-Disposition: inline In-Reply-To: <4E7B0DE6.9020807-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Sep 22, 2011 at 12:28:54PM +0200, Oliver Hartkopp wrote: > This patch adds support for SJW user settings to not set the synchronization > jump width (SJW) to 1 in any case when using the in-kernel bittiming > calculation. > > The ip-tool from iproute2 already supports to pass the user defined SJW > value. The given SJW value is sanitized with the controller specific sjw_max > and the calculated tseg2 value. As the SJW can have values up to 4 providing > this value will lead to the maximum possible SJW automatically. A higher SJW > allows higher controller oscillator tolerances. > Since both iproute2 & the bittiming calculation seem to be ready for it, activating the SJW setting looks like a good idea. Thanks, Kurt Acked-by: Kurt Van Dijck