From: David Miller <davem@davemloft.net>
To: yoshihiro.shimoda.uh@renesas.com
Cc: nobuhiro.iwamatsu.yj@renesas.com, sfr@canb.auug.org.au,
netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] net: sh_eth: fix build failure
Date: Fri, 30 Sep 2011 03:54:49 -0400 (EDT) [thread overview]
Message-ID: <20110930.035449.1012299223616580574.davem@davemloft.net> (raw)
In-Reply-To: <4E857506.5030501@renesas.com>
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Date: Fri, 30 Sep 2011 16:51:34 +0900
> 2011/09/30 15:55, Nobuhiro Iwamatsu wrote:
>> 2011/9/30 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>:
> < snip >
>>> +#include <linux/kernel.h>
>>> +#include <linux/spinlock.h>
>> These are not required.
>
> The Documentation/SubmitChecklist says the following:
>
> ========================================================
> 1: If you use a facility then #include the file that defines/declares
> that facility. Don't depend on other header files pulling in ones
> that you use.
> ========================================================
>
> The sh_eth driver uses spinlock functions and some macros of kernel.h.
> So, I think that I have to write their "#include" in the driver.
Agreed.
next prev parent reply other threads:[~2011-09-30 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 3:16 [PATCH] net: sh_eth: fix build failure Yoshihiro Shimoda
2011-09-30 6:55 ` Nobuhiro Iwamatsu
2011-09-30 7:51 ` Yoshihiro Shimoda
2011-09-30 7:54 ` David Miller [this message]
2011-09-30 19:36 ` Nobuhiro Iwamatsu
2011-10-03 18:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930.035449.1012299223616580574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=sfr@canb.auug.org.au \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).