From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH next 2/7] 8139cp : removal of headers.
Date: Fri, 30 Sep 2011 14:13:40 -0400 (EDT) [thread overview]
Message-ID: <20110930.141340.698884892100746534.davem@davemloft.net> (raw)
In-Reply-To: <20110930162649.GA32195@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Fri, 30 Sep 2011 18:26:49 +0200
> I am sceptical about the value in including so much headers for
> rather common things at the network device driver level. After all
> the code is supposed to be cross-platform, modular or monolithic
> built.
We are trying very hard to split out the implicit inclusions of
one set of headers into another.
So you absolutely should always include the headers for all features
you explicitly use.
next prev parent reply other threads:[~2011-09-30 18:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 10:36 [PATCH next 0/7] Pull request for 'davem-next.misc' branch (#2) Francois Romieu
2011-09-30 10:36 ` [PATCH next 1/7] bnx2: don't request firmware when there's no userspace Francois Romieu
2011-10-03 18:09 ` David Miller
2011-09-30 10:37 ` [PATCH next 2/7] 8139cp : removal of headers Francois Romieu
2011-09-30 14:03 ` Ben Hutchings
2011-09-30 16:26 ` Francois Romieu
2011-09-30 18:13 ` David Miller [this message]
2011-09-30 10:37 ` [PATCH next 3/7] atm/iphase : removal of PCI space dereferences Francois Romieu
2011-10-03 18:09 ` David Miller
2011-09-30 10:38 ` [PATCH next 4/7] sc92031: use standard #defines from mii.h Francois Romieu
2011-10-03 18:09 ` David Miller
2011-09-30 10:38 ` [PATCH next 5/7] rtl8150: removal of forward declarations Francois Romieu
2011-10-03 18:09 ` David Miller
2011-09-30 10:38 ` [PATCH next 6/7] drivers/net/ethernet: remove unused #define Francois Romieu
2011-10-03 18:09 ` David Miller
2011-09-30 10:39 ` [PATCH next 7/7] tehuti: shorten PCI device table Francois Romieu
2011-10-03 18:10 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-09-29 22:52 [PATCH next 0/7] Pull request for 'davem-next.misc' branch Francois Romieu
2011-09-29 22:53 ` [PATCH next 2/7] 8139cp : removal of headers Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930.141340.698884892100746534.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).