From: Stephen Hemminger <shemminger@vyatta.com>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
eric.dumazet@gmail.com, bhutchings@solarflare.com,
fubar@us.ibm.com, andy@greyhouse.net, tgraf@infradead.org,
ebiederm@xmission.com, mirqus@gmail.com, kaber@trash.net,
greearb@candelatech.com
Subject: Re: [RFC patch net-next-2.6] net: introduce ethernet teaming device
Date: Fri, 30 Sep 2011 09:26:19 -0700 [thread overview]
Message-ID: <20110930092619.6b45087d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1317386643-3041-1-git-send-email-jpirko@redhat.com>
On Fri, 30 Sep 2011 14:44:03 +0200
Jiri Pirko <jpirko@redhat.com> wrote:
> +static struct rtnl_link_stats64 *team_get_stats(struct net_device *dev,
> + struct rtnl_link_stats64 *stats)
> +{
> + struct team *team = netdev_priv(dev);
> + struct rtnl_link_stats64 temp;
> + struct team_port *port;
> +
> + memset(stats, 0, sizeof(*stats));
> +
> + rcu_read_lock();
> + list_for_each_entry_rcu(port, &team->port_list, list) {
> + const struct rtnl_link_stats64 *pstats;
You need to use u64_stats_sync macros to make this safe on 32 bit
mode.
Also, I am not sure about the handling of speed and duplex.
There are people who do active backup with links of different speeds.
The team device doesn't seem to handle hardware offload features
as completely as it should. The TSO and transmit checksumming should
be the union of the teamed ports.
next prev parent reply other threads:[~2011-09-30 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 12:44 [RFC patch net-next-2.6] net: introduce ethernet teaming device Jiri Pirko
2011-09-30 16:26 ` Stephen Hemminger [this message]
2011-10-01 8:15 ` Jiri Pirko
2011-10-01 18:15 ` Jesse Gross
2011-10-03 11:37 ` Jiri Pirko
2011-10-03 16:20 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930092619.6b45087d@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=greearb@candelatech.com \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).