From: David Miller <davem@davemloft.net>
To: david.ward@ll.mit.edu
Cc: kaber@trash.net, netdev@vger.kernel.org,
herbert@gondor.hengli.com.au, krkumar2@in.ibm.com
Subject: Re: macvlan/macvtap patch in patchwork
Date: Sun, 02 Oct 2011 20:33:06 -0400 (EDT) [thread overview]
Message-ID: <20111002.203306.17836844704730738.davem@davemloft.net> (raw)
In-Reply-To: <4E825804.2010603@ll.mit.edu>
From: "Ward, David - 0663 - MITLL" <david.ward@ll.mit.edu>
Date: Tue, 27 Sep 2011 19:11:00 -0400
> The problem is that I was forwarding the frame to the lowerdev the
> wrong way, by calling vlan->forward which serves a different purpose.
> vlan->forward points to dev_forward_skb for macvlan (so the forwarding
> works fine), but it points to macvtap_forward for macvtap (which
> causes an oops when called here). We need to always use
> dev_forward_skb to forward to a lowerdev.
Thanks for explaining, patch applied.
prev parent reply other threads:[~2011-10-03 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 19:14 macvlan/macvtap patch in patchwork David Miller
2011-09-27 23:10 ` Ward, David - 0663 - MITLL
2011-09-27 23:11 ` Ward, David - 0663 - MITLL
2011-10-03 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002.203306.17836844704730738.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=herbert@gondor.hengli.com.au \
--cc=kaber@trash.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).