From: David Miller <davem@davemloft.net>
To: zheng.z.yan@intel.com
Cc: netdev@vger.kernel.org, ilpo.jarvinen@helsinki.fi,
nanditad@google.com, ycheng@google.com
Subject: Re: [PATCH v3] tcp: properly update lost_cnt_hint during shifting
Date: Sun, 02 Oct 2011 20:33:46 -0400 (EDT) [thread overview]
Message-ID: <20111002.203346.1030463582070299609.davem@davemloft.net> (raw)
In-Reply-To: <4E88737E.5030906@intel.com>
From: "Yan, Zheng" <zheng.z.yan@intel.com>
Date: Sun, 02 Oct 2011 22:21:50 +0800
> lost_skb_hint is used by tcp_mark_head_lost() to mark the first unhandled skb.
> lost_cnt_hint is the number of packets or sacked packets before the lost_skb_hint;
> When shifting a skb that is before the lost_skb_hint, if tcp_is_fack() is ture,
> the skb has already been counted in the lost_cnt_hint; if tcp_is_fack() is false,
> tcp_sacktag_one() will increase the lost_cnt_hint. So tcp_shifted_skb() does not
> need to adjust the lost_cnt_hint by itself. When shifting a skb that is equal to
> lost_skb_hint, the shifted packets will not be counted by tcp_mark_head_lost().
> So tcp_shifted_skb() should adjust the lost_cnt_hint even tcp_is_fack(tp) is true.
>
> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
Applied, thanks.
prev parent reply other threads:[~2011-10-03 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 14:21 [PATCH v3] tcp: properly update lost_cnt_hint during shifting Yan, Zheng
2011-10-03 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002.203346.1030463582070299609.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=nanditad@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).