* [patch] bnx2x: remove some dead code
@ 2011-10-05 5:49 Dan Carpenter
2011-10-05 21:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-10-05 5:49 UTC (permalink / raw)
To: Eilon Greenstein; +Cc: netdev, kernel-janitors
This code is after the break statement so it never gets used. The
"vlan_mac_obj" variable does get initialized properly, so we can just
delete this.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 04f17a1..6486ab8 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -4353,8 +4353,6 @@ static inline void bnx2x_handle_classification_eqe(struct bnx2x *bp,
vlan_mac_obj = &bp->fp[cid].mac_obj;
break;
- vlan_mac_obj = &bp->fp[cid].mac_obj;
-
case BNX2X_FILTER_MCAST_PENDING:
/* This is only relevant for 57710 where multicast MACs are
* configured as unicast MACs using the same ramrod.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] bnx2x: remove some dead code
2011-10-05 5:49 [patch] bnx2x: remove some dead code Dan Carpenter
@ 2011-10-05 21:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-10-05 21:52 UTC (permalink / raw)
To: dan.carpenter; +Cc: eilong, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 5 Oct 2011 08:49:18 +0300
> This code is after the break statement so it never gets used. The
> "vlan_mac_obj" variable does get initialized properly, so we can just
> delete this.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-05 21:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-05 5:49 [patch] bnx2x: remove some dead code Dan Carpenter
2011-10-05 21:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).