From: Stephen Hemminger <shemminger@vyatta.com>
To: Mihai Maruseac <mihai.maruseac@gmail.com>
Cc: davem@davemloft.net, eric.dumazet@gmail.com,
mirq-linux@rere.qmqm.pl, therbert@google.com, jpirko@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dbaluta@ixiacom.com, Mihai Maruseac <mmaruseac@ixiacom.com>
Subject: Re: [PATCH] dev: use name hash for dev_seq_ops.
Date: Fri, 7 Oct 2011 09:24:45 -0700 [thread overview]
Message-ID: <20111007092445.4f097ed9@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1318000849-2531-1-git-send-email-mmaruseac@ixiacom.com>
On Fri, 7 Oct 2011 18:20:49 +0300
Mihai Maruseac <mihai.maruseac@gmail.com> wrote:
> Instead of using the dev->next chain and trying to resync at each call to
> dev_seq_start, use this hash and store bucket number and bucket offset in
> seq->private field.
>
> Tests revealed the following results for ifconfig > /dev/null
> * 1000 interfaces:
> * 0.114s without patch
> * 0.020s with patch
> * 3000 interfaces:
> * 0.489s without patch
> * 0.048s with patch
> * 5000 interfaces:
> * 1.363s without patch
> * 0.131s with patch
>
> As one can notice the improvement is of 1 order of magnitude.
Good idea,
This will change the ordering of entries in /proc which may upset
some program, not a critical flaw but worth noting.
Rather than recording the bucket and offset of last entry, another
alternative would be to just record the ifindex.
Also ifconfig is considered deprecated and replaced by ip commands
for general use.
next prev parent reply other threads:[~2011-10-07 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 15:20 [PATCH] dev: use name hash for dev_seq_ops Mihai Maruseac
2011-10-07 16:24 ` Stephen Hemminger [this message]
2011-10-08 7:22 ` Mihai Maruseac
2011-10-10 8:43 ` Mihai Maruseac
2011-10-11 5:55 ` Stephen Hemminger
2011-10-12 10:08 ` Mihai Maruseac
2011-10-12 9:49 ` [PATCH] dev: use ifindex " Mihai Maruseac
2011-10-12 9:57 ` Mihai Maruseac
2011-10-12 9:59 ` Mihai Maruseac
2011-10-12 15:50 ` Stephen Hemminger
2011-10-14 12:20 ` Mihai Maruseac
2011-10-14 9:53 ` Mihai Maruseac
2011-10-14 12:53 ` Eric Dumazet
2011-10-17 8:03 ` Daniel Baluta
2011-10-17 15:12 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2011-10-20 8:01 [PATCH] dev: use name " Mihai Maruseac
2011-10-20 20:17 ` David Miller
2011-10-21 6:45 ` Mihai Maruseac
2011-10-21 6:52 ` Eric Dumazet
2011-10-21 6:55 ` David Miller
2011-10-21 17:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007092445.4f097ed9@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.maruseac@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mmaruseac@ixiacom.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).