From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: danborkmann@iogearbox.net, netdev@vger.kernel.org
Subject: Re: [PATCH] af_packet: remove unnecessary BUG_ON() in tpacket_destruct_skb
Date: Mon, 10 Oct 2011 14:09:51 -0400 (EDT) [thread overview]
Message-ID: <20111010.140951.1248594231055254215.davem@davemloft.net> (raw)
In-Reply-To: <1318266304.3227.18.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 10 Oct 2011 19:05:04 +0200
> Le lundi 10 octobre 2011 à 18:52 +0200, danborkmann@iogearbox.net a
> écrit :
>> If skb is NULL, then stack trace is thrown anyway on dereference.
>> Therefore, the stack trace triggered by BUG_ON is duplicate.
>>
>> Signed-off-by: Daniel Borkmann <danborkmann@googlemail.com>
>> Cc: Eric Dumazet <eric.dumazet@gmail.com>
>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, but please make patches like this against the net-next tree
in which the af_packet.c code had changed quite a bit and therefore
I had to munch your patch to get it to apply.
prev parent reply other threads:[~2011-10-10 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 16:52 [PATCH] af_packet: remove unnecessary BUG_ON() in tpacket_destruct_skb danborkmann
2011-10-10 17:05 ` Eric Dumazet
2011-10-10 18:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010.140951.1248594231055254215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=danborkmann@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).