From: David Miller <davem@davemloft.net>
To: corone.il.han@gmail.com
Cc: isdn@linux-pingi.de, netdev@vger.kernel.org
Subject: Re: [PATCH] isdn: add missing cast operator in drivers/isdn/sc/init.c
Date: Mon, 10 Oct 2011 14:18:49 -0400 (EDT) [thread overview]
Message-ID: <20111010.141849.369289346368485205.davem@davemloft.net> (raw)
In-Reply-To: <1318244560-19213-1-git-send-email-corone.il.han@gmail.com>
From: Il Han <corone.il.han@gmail.com>
Date: Mon, 10 Oct 2011 20:02:40 +0900
> Add (void __iomem *) to convert the value to the proper type before passing it to readl().
>
> Signed-off-by: Il Han <corone.il.han@gmail.com>
I've rejected this patch already in the past, and this is because the correct
fix is to change the type of rambase and the variables and datastructures
it is initialized from.
prev parent reply other threads:[~2011-10-10 18:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 11:02 [PATCH] isdn: add missing cast operator in drivers/isdn/sc/init.c Il Han
2011-10-10 18:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010.141849.369289346368485205.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=corone.il.han@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).