* [PATCH] gro: refetch inet6_protos[] after pulling ext headers
@ 2011-10-09 8:34 Yan, Zheng
2011-10-09 9:33 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Yan, Zheng @ 2011-10-09 8:34 UTC (permalink / raw)
To: netdev@vger.kernel.org, Herbert Xu, davem@davemloft.net
ipv6_gro_receive() doesn't update the protocol ops after pulling
the ext headers. It looks like a typo.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
---
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
index 3b5669a..d27c797 100644
--- a/net/ipv6/af_inet6.c
+++ b/net/ipv6/af_inet6.c
@@ -875,6 +875,7 @@ static struct sk_buff **ipv6_gro_receive(struct sk_buff **head,
skb_reset_transport_header(skb);
__skb_push(skb, skb_gro_offset(skb));
+ ops = rcu_dereference(inet6_protos[proto]);
if (!ops || !ops->gro_receive)
goto out_unlock;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gro: refetch inet6_protos[] after pulling ext headers
2011-10-09 8:34 [PATCH] gro: refetch inet6_protos[] after pulling ext headers Yan, Zheng
@ 2011-10-09 9:33 ` Eric Dumazet
2011-10-10 18:26 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2011-10-09 9:33 UTC (permalink / raw)
To: Yan, Zheng; +Cc: netdev@vger.kernel.org, Herbert Xu, davem@davemloft.net
Le dimanche 09 octobre 2011 à 16:34 +0800, Yan, Zheng a écrit :
> ipv6_gro_receive() doesn't update the protocol ops after pulling
> the ext headers. It looks like a typo.
>
> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
> ---
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index 3b5669a..d27c797 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -875,6 +875,7 @@ static struct sk_buff **ipv6_gro_receive(struct sk_buff **head,
> skb_reset_transport_header(skb);
> __skb_push(skb, skb_gro_offset(skb));
>
> + ops = rcu_dereference(inet6_protos[proto]);
> if (!ops || !ops->gro_receive)
> goto out_unlock;
Good catch !
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gro: refetch inet6_protos[] after pulling ext headers
2011-10-09 9:33 ` Eric Dumazet
@ 2011-10-10 18:26 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-10-10 18:26 UTC (permalink / raw)
To: eric.dumazet; +Cc: zheng.z.yan, netdev, herbert
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 09 Oct 2011 11:33:51 +0200
> Le dimanche 09 octobre 2011 à 16:34 +0800, Yan, Zheng a écrit :
>> ipv6_gro_receive() doesn't update the protocol ops after pulling
>> the ext headers. It looks like a typo.
>>
>> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
...
>
> Good catch !
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-10 18:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-09 8:34 [PATCH] gro: refetch inet6_protos[] after pulling ext headers Yan, Zheng
2011-10-09 9:33 ` Eric Dumazet
2011-10-10 18:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).