* [PATCH net-next] ipv6: Remove superfluous NULL pointer check in ipv6_local_rxpmtu
@ 2011-10-11 12:01 Steffen Klassert
2011-10-19 3:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steffen Klassert @ 2011-10-11 12:01 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The pointer to mtu_info is taken from the common buffer
of the skb, thus it can't be a NULL pointer. This patch
removes this check on mtu_info.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
net/ipv6/datagram.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/datagram.c b/net/ipv6/datagram.c
index b46e9f8..e248069 100644
--- a/net/ipv6/datagram.c
+++ b/net/ipv6/datagram.c
@@ -297,10 +297,6 @@ void ipv6_local_rxpmtu(struct sock *sk, struct flowi6 *fl6, u32 mtu)
ipv6_addr_copy(&iph->daddr, &fl6->daddr);
mtu_info = IP6CBMTU(skb);
- if (!mtu_info) {
- kfree_skb(skb);
- return;
- }
mtu_info->ip6m_mtu = mtu;
mtu_info->ip6m_addr.sin6_family = AF_INET6;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: Remove superfluous NULL pointer check in ipv6_local_rxpmtu
2011-10-11 12:01 [PATCH net-next] ipv6: Remove superfluous NULL pointer check in ipv6_local_rxpmtu Steffen Klassert
@ 2011-10-19 3:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-10-19 3:51 UTC (permalink / raw)
To: steffen.klassert; +Cc: netdev
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Tue, 11 Oct 2011 14:01:02 +0200
> The pointer to mtu_info is taken from the common buffer
> of the skb, thus it can't be a NULL pointer. This patch
> removes this check on mtu_info.
>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-19 3:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 12:01 [PATCH net-next] ipv6: Remove superfluous NULL pointer check in ipv6_local_rxpmtu Steffen Klassert
2011-10-19 3:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).