netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: David Lamparter <equinox@diac24.net>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	netdev <netdev@vger.kernel.org>
Subject: Re: e100 + VLANs?
Date: Tue, 11 Oct 2011 16:38:55 -0700	[thread overview]
Message-ID: <20111011163855.0000646f@unknown> (raw)
In-Reply-To: <20111011152917.GE2840382@jupiter.n2.diac24.net>

[-- Attachment #1: Type: text/plain, Size: 1820 bytes --]

On Tue, 11 Oct 2011 08:29:18 -0700
David Lamparter <equinox@diac24.net> wrote:

> On Tue, Oct 11, 2011 at 04:56:23PM +0400, Michael Tokarev wrote:
> > So it looks like the card merely ignores these packets.
> > 
> > So little result for so much efforts... :(
> > 
> > But it is not really that bad I think - it is an obsolete hardware.
> 
> The knowledge and code for this is actually around line 1142 of e100.c:
>         if (nic->mac >= mac_82558_D101_A4) {
>                 config->fc_disable = 0x1;       /* 1=Tx fc off, 0=Tx fc on */
>                 config->mwi_enable = 0x1;       /* 1=enable, 0=disable */
>                 config->standard_tcb = 0x0;     /* 1=standard, 0=extended */
>                 config->rx_long_ok = 0x1;       /* 1=VLANs ok, 0=standard */
> 
> where rx_long_ok is the configuration bit to enable frame reception
> for >1514 byte frames. I guess your card is < mac_82558_D101_A4...
> 
> (cf. "Intel 8255x 10/100 Mbps Ethernet Controller Family Open Source
> Software Developer Manual" page 78/86 - "Long Receive OK. This bit is
> reserved on the 82557 and should be set to 0. When this bit is set on
> the 82558 or 82559, the device considers received frames that have
> a data field longer than 1500 bytes as good frames.")

David, thank you for posting that, while you were typing I was
researching the same thing, so FWIW, I concur with your conclusion.

ouch, OP your hardware is really really old:
> 00:12.0 Ethernet controller: Intel Corporation 82557/8/9/0/1 Ethernet Pro 100 (rev 02)
> Subsystem: Intel Corporation EtherExpress PRO/100B (TX)

rev 2 is D100_C, which is 82557.

the hardware is NOT capable of long receives (i.e. vlan packets).
If it was then they should generally fit in the receive buffer and be
handled and not discarded.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 834 bytes --]

  reply	other threads:[~2011-10-11 23:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-08 10:08 e100 + VLANs? Michael Tokarev
2011-10-08 16:24 ` Eric Dumazet
2011-10-08 18:34   ` Jeff Kirsher
2011-10-10 10:19     ` David Lamparter
2011-10-10 14:57       ` Michael Tokarev
2011-10-10 15:05         ` Eric Dumazet
2011-10-10 15:13           ` David Lamparter
2011-10-10 15:23             ` Eric Dumazet
2011-10-10 15:28               ` David Lamparter
2011-10-10 15:50                 ` Eric Dumazet
2011-10-10 16:51             ` Michael Tokarev
     [not found]             ` <4E932278.8010802@tls.msk.ru>
2011-10-11  9:51               ` Michael Tokarev
2011-10-11 11:25                 ` Eric Dumazet
2011-10-11 11:59                   ` Michael Tokarev
2011-10-11 12:04                     ` Eric Dumazet
2011-10-11 12:56                       ` Michael Tokarev
2011-10-11 15:29                         ` David Lamparter
2011-10-11 23:38                           ` Jesse Brandeburg [this message]
2011-10-13  9:22                             ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111011163855.0000646f@unknown \
    --to=jesse.brandeburg@intel.com \
    --cc=equinox@diac24.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=mjt@tls.msk.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).