From: Flavio Leitner <fbl@redhat.com>
To: Gao feng <gaofeng@cn.fujitsu.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, eric.dumazet@gmail.com
Subject: Re: [PATCH v2] netconsole: enable netconsole can make net_device refcnt incorrent
Date: Wed, 12 Oct 2011 10:23:44 -0300 [thread overview]
Message-ID: <20111012102344.0b718260@asterix.rh> (raw)
In-Reply-To: <1318385291-15483-1-git-send-email-gaofeng@cn.fujitsu.com>
On Wed, 12 Oct 2011 10:08:11 +0800
Gao feng <gaofeng@cn.fujitsu.com> wrote:
> There is no check if netconsole is enabled current.
> so when exec echo 1 > enabled;
> the reference of net_device will increment always.
>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
> ---
> drivers/net/netconsole.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
Looks better, thanks!
Acked-by: Flavio Leitner <fbl@redhat.com>
fbl
next prev parent reply other threads:[~2011-10-12 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 2:08 [PATCH v2] netconsole: enable netconsole can make net_device refcnt incorrent Gao feng
2011-10-12 13:23 ` Flavio Leitner [this message]
2011-10-19 3:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012102344.0b718260@asterix.rh \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).