From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, rayagond@vayavyalabs.com
Subject: Re: [net-next 1/5] stmmac: add CHAINED descriptor mode support (V2)
Date: Thu, 13 Oct 2011 16:39:46 -0400 (EDT) [thread overview]
Message-ID: <20111013.163946.859494070937160730.davem@davemloft.net> (raw)
In-Reply-To: <1318426688-9419-2-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Wed, 12 Oct 2011 15:38:04 +0200
> +#if defined(CONFIG_STMMAC_RING)
> +
> +static unsigned int stmmac_jumbo_frm(struct stmmac_priv *priv,
> + struct sk_buff *skb, int csum_insertion)
> +{
This is not exactly what I meant.
In your original patch, two or three line snippets of code were conditionalized.
That's what I wanted you to do here. Keep as much common code around as possible
in the driver *.c file, but the small 2 or 3 line conditional parts are implemented
in very small well contained inline functions implemented in a header file.
These small, 2 or 3 line, inline functions are where the ifdefs go.
I didn't mean to replicate all of the functions, in their entirety, into some
header file.
You might was well put the entire driver into a header file, then you can add
all the ifdefs you want :-)
next prev parent reply other threads:[~2011-10-13 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 13:38 [net-next 0/5] stmmac: update to Oct 2011 version (V2) Giuseppe CAVALLARO
2011-10-12 13:38 ` [net-next 1/5] stmmac: add CHAINED descriptor mode support (V2) Giuseppe CAVALLARO
2011-10-13 20:39 ` David Miller [this message]
2011-10-14 7:10 ` Giuseppe CAVALLARO
2011-10-12 13:38 ` [net-next 2/5] stmmac: allow mtu bigger than 1500 in case of normal desc (V2) Giuseppe CAVALLARO
2011-10-12 19:58 ` Eric Dumazet
2011-10-14 7:15 ` Giuseppe CAVALLARO
2011-10-12 13:38 ` [net-next 3/5] stmmac: protect tx process with lock (V2) Giuseppe CAVALLARO
2011-10-12 13:38 ` [net-next 4/5] stmmac: Stop advertising 1000Base capabilties for non GMII iface (V2) Giuseppe CAVALLARO
2011-10-12 13:38 ` [net-next 5/5] stmmac: update the driver version and doc (V2) Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013.163946.859494070937160730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).