* [PATCH net-next] sky2: fix skb truesize underestimation
@ 2011-10-13 21:11 Eric Dumazet
2011-10-13 21:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2011-10-13 21:11 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Stephen Hemminger
sky2 allocates a page per skb fragment. We must account
PAGE_SIZE increments on skb->truesize, not the actual frag length.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Stephen Hemminger <shemminger@vyatta.com>
---
drivers/net/ethernet/marvell/sky2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 6895e3b..9263490 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -2486,7 +2486,7 @@ static void skb_put_frags(struct sk_buff *skb, unsigned int hdr_space,
frag->size = size;
skb->data_len += size;
- skb->truesize += size;
+ skb->truesize += PAGE_SIZE;
skb->len += size;
length -= size;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] sky2: fix skb truesize underestimation
2011-10-13 21:11 [PATCH net-next] sky2: fix skb truesize underestimation Eric Dumazet
@ 2011-10-13 21:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-10-13 21:13 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, shemminger
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 13 Oct 2011 23:11:30 +0200
> sky2 allocates a page per skb fragment. We must account
> PAGE_SIZE increments on skb->truesize, not the actual frag length.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-13 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-13 21:11 [PATCH net-next] sky2: fix skb truesize underestimation Eric Dumazet
2011-10-13 21:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).