From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] smsc911x: Add regulator support Date: Mon, 17 Oct 2011 13:36:14 +0100 Message-ID: <20111017123614.GC27266@opensource.wolfsonmicro.com> References: <1318834597-3479-1-git-send-email-robert.marklund@stericsson.com> <20111017105256.GG5448@sirena.org.uk> <2B1D156D95AE9B4EAD379CB9E465FE7324AB09DE76@EXDCVYMBSTM005.EQ1STM.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "netdev@vger.kernel.org" , Steve Glendinning , Mathieu Poirer To: Robert MARKLUND Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52367 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230Ab1JQMgQ (ORCPT ); Mon, 17 Oct 2011 08:36:16 -0400 Content-Disposition: inline In-Reply-To: <2B1D156D95AE9B4EAD379CB9E465FE7324AB09DE76@EXDCVYMBSTM005.EQ1STM.local> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Oct 17, 2011 at 01:30:06PM +0200, Robert MARKLUND wrote: You should fix your mail client to word wrap within paragraphs, I've reformatted it for legibility. Also leave a blank line between paragraphs for the same reason. > > No, this is broken - look at how other devices use the regulator API. > > The driver should just request and use the regulators unconditionally > > and let the stubbing and mapping facilities the API has deal with > > ensuring that they always succeed. > So what you mean is get them and use them and ignore all the return > codes, and let the FW take care of the error handling ? No, you should do what all the other drivers do and actually pay attention to the errors. If we can't get power to the device that's a pretty serious problem and the driver ought to fail. > > As a side note the use of "pdata" as a name for the driver internal data > > is really not helpful, pdata is traditionally the platform data passed > > in by the machine (which would be even more broken). > In the driver they have used this name for this structure throughout > the file I just followed that. Personally I think it will be more > confusing to change the name of this structure in just this new > function. I think someone should send a patch renaming the data throughout the entire driver, it's a terrible name for an embedded context.