From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] smsc911x: Add regulator support Date: Mon, 17 Oct 2011 15:33:58 +0100 Message-ID: <20111017143358.GI5448@sirena.org.uk> References: <1318834597-3479-1-git-send-email-robert.marklund@stericsson.com> <20111017105256.GG5448@sirena.org.uk> <2B1D156D95AE9B4EAD379CB9E465FE7324AB09DE76@EXDCVYMBSTM005.EQ1STM.local> <20111017123614.GC27266@opensource.wolfsonmicro.com> <2B1D156D95AE9B4EAD379CB9E465FE7324AB09E052@EXDCVYMBSTM005.EQ1STM.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "netdev@vger.kernel.org" , Steve Glendinning , Mathieu Poirer To: Robert MARKLUND Return-path: Received: from cassiel.sirena.org.uk ([80.68.93.111]:47391 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250Ab1JQOeA (ORCPT ); Mon, 17 Oct 2011 10:34:00 -0400 Content-Disposition: inline In-Reply-To: <2B1D156D95AE9B4EAD379CB9E465FE7324AB09E052@EXDCVYMBSTM005.EQ1STM.local> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Oct 17, 2011 at 04:13:47PM +0200, Robert MARKLUND wrote: > > You should fix your mail client to word wrap within paragraphs, I've > > reformatted it for legibility. Also leave a blank line between > > paragraphs for the same reason. > I have tried but it's not as easy as it sounds :) > Does it look better now ? Yes, thanks. > > No, you should do what all the other drivers do and actually pay > > attention to the errors. If we can't get power to the device that's a > > pretty serious problem and the driver ought to fail. > Then I don't understand the initial comment. > Can you please elaborate that one. If we fail to grab a critical resource for the device like the power supply then we should be failing passing the error back. As I keep saying this is what all the other regulator consumers are doing.