From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Robert MARKLUND <robert.marklund@stericsson.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Steve Glendinning <steve.glendinning@smsc.com>,
Mathieu Poirer <mathieu.poirier@linaro.org>
Subject: Re: [PATCH] smsc911x: Add regulator support
Date: Mon, 17 Oct 2011 16:38:02 +0100 [thread overview]
Message-ID: <20111017153802.GK5448@sirena.org.uk> (raw)
In-Reply-To: <2B1D156D95AE9B4EAD379CB9E465FE7324AB09E0EE@EXDCVYMBSTM005.EQ1STM.local>
On Mon, Oct 17, 2011 at 05:28:08PM +0200, Robert MARKLUND wrote:
> > If we fail to grab a critical resource for the device like the power
> > supply then we should be failing passing the error back. As I keep
> > saying this is what all the other regulator consumers are doing.
> Most of the boards out there don't have any regulators for the chip(power is always on).
> So when we can't get the regulator, we assume that the power is already on.
> That's why it hasn't been implemented before.
> So adding this functionality will make all the other boards out there fail, to start the driver.
Clearly this issue is going to apply to every single user of the
regulator API which is one reason why it's insane to open code handling
of missing regulators in individual regulator consumer drivers. As I
keep saying you should unconditionally use the regulators and let the
regulator API facilities for stubbing itself out deal with this.
prev parent reply other threads:[~2011-10-17 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 6:56 [PATCH] smsc911x: Add regulator support Robert Marklund
2011-10-17 10:52 ` Mark Brown
2011-10-17 11:30 ` Robert MARKLUND
2011-10-17 12:36 ` Mark Brown
2011-10-17 14:13 ` Robert MARKLUND
2011-10-17 14:33 ` Mark Brown
2011-10-17 15:28 ` Robert MARKLUND
2011-10-17 15:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017153802.GK5448@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robert.marklund@stericsson.com \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).