From: David Miller <davem@davemloft.net>
To: cloud.ren@Atheros.com
Cc: Luis.Rodriguez@Atheros.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver
Date: Wed, 19 Oct 2011 03:33:24 -0400 (EDT) [thread overview]
Message-ID: <20111019.033324.1233460304204609569.davem@davemloft.net> (raw)
In-Reply-To: <1319009213-20627-1-git-send-email-cloud.ren@atheros.com>
From: <cloud.ren@Atheros.com>
Date: Wed, 19 Oct 2011 15:26:53 +0800
> +#define HW_PRINT(_klv, _fmt, _args...) \
> + if (ALX_HW_MSG_LV_##_klv || ALX_HW_MSG_LV_ALL) {\
> + printk(KERN_##_klv ALX_HW_MSG_PFX_NAME "%s: " _fmt, \
> + __func__, ## _args); \
> + }
Do not create your own network driver debugging facilities and macros
for logging messages, we have rich debugging and logging level
interfaces that network drivers can use exactly for this purpose.
next prev parent reply other threads:[~2011-10-19 7:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 7:26 [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver cloud.ren
2011-10-19 7:33 ` David Miller [this message]
2011-10-19 7:44 ` Ren, Cloud
2011-10-19 7:50 ` David Miller
2011-10-19 7:53 ` Ren, Cloud
2011-10-19 7:56 ` Joe Perches
2011-10-19 22:21 ` Francois Romieu
2011-10-19 22:59 ` Joe Perches
2011-10-20 7:29 ` Ren, Cloud
2011-10-20 8:48 ` David Miller
2011-10-28 2:56 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2011-10-20 6:46 cloud.ren
2011-10-20 8:45 ` David Miller
2011-10-20 9:00 ` Joe Perches
2011-10-20 9:23 ` Ren, Cloud
2011-10-20 9:25 ` David Miller
2011-10-20 9:48 ` Ren, Cloud
2011-10-20 20:33 ` Luis R. Rodriguez
2011-10-21 2:21 ` Ren, Cloud
2011-10-21 2:36 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019.033324.1233460304204609569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Luis.Rodriguez@Atheros.com \
--cc=cloud.ren@Atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).