From: David Miller <davem@davemloft.net>
To: fbl@redhat.com
Cc: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net
Subject: Re: [PATCH net-next] bonding: fix wrong port enabling in 802.3ad
Date: Wed, 19 Oct 2011 03:53:43 -0400 (EDT) [thread overview]
Message-ID: <20111019.035343.1749126014967505732.davem@davemloft.net> (raw)
In-Reply-To: <1318526483-16073-1-git-send-email-fbl@redhat.com>
From: Flavio Leitner <fbl@redhat.com>
Date: Thu, 13 Oct 2011 14:21:23 -0300
> The port shouldn't be enabled unless its current MUX
> state is DISTRIBUTING which is correctly handled by
> ad_mux_machine(), otherwise the packet sent can be
> lost because the other end may not be ready.
>
> The issue happens on every port initialization, but
> as the ports are expected to move quickly to DISTRIBUTING,
> it doesn't cause much problem. However, it does cause
> constant packet loss if the other peer has the port
> configured to stay in STANDBY (i.e. SYNC set to OFF).
>
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
Applied, thanks.
next prev parent reply other threads:[~2011-10-19 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 17:21 [PATCH net-next] bonding: fix wrong port enabling in 802.3ad Flavio Leitner
2011-10-13 17:46 ` Jay Vosburgh
2011-10-13 18:20 ` Flavio Leitner
2011-10-19 7:53 ` David Miller [this message]
[not found] <CAGMsbm4DMPfT6zSZp+fH2XB_gRUHR9FSRDxcwBJVCOhUi4j9AA@mail.gmail.com>
2011-10-23 15:04 ` Kartik Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019.035343.1749126014967505732.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).