From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: Ian.Campbell@citrix.com, krkumar2@in.ibm.com,
rusty@rustcorp.com.au, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] Fix guest memory leak and panic
Date: Wed, 19 Oct 2011 19:42:05 -0400 (EDT) [thread overview]
Message-ID: <20111019.194205.2298875957485608359.davem@davemloft.net> (raw)
In-Reply-To: <1319015259.3103.3.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 19 Oct 2011 11:07:39 +0200
>> From 369022220db31efb9c261cbabcb890a4d216a176 Mon Sep 17 00:00:00 2001
>> From: Ian Campbell <ian.campbell@citrix.com>
>> Date: Tue, 18 Oct 2011 09:59:37 +0100
>> Subject: [PATCH] net: do not take an additional reference in skb_frag_set_page
>>
>> I audited all of the callers in the tree and only one of them (pktgen) expects
>> it to do so. Taking this reference is pretty obviously confusing and error
>> prone.
>>
>> In particular I looked at the following commits which switched callers of
>> (__)skb_frag_set_page to the skb paged fragment api:
...
>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
...
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2011-10-19 23:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 8:05 [PATCH] Fix guest memory leak and panic Krishna Kumar
2011-10-18 8:36 ` Ian Campbell
2011-10-18 9:47 ` Ian Campbell
2011-10-18 10:46 ` Krishna Kumar2
2011-10-18 10:50 ` Ian Campbell
2011-10-18 13:22 ` Krishna Kumar2
2011-10-19 23:38 ` David Miller
2011-10-18 13:20 ` Eric Dumazet
2011-10-19 8:55 ` Ian Campbell
2011-10-19 9:07 ` Eric Dumazet
2011-10-19 23:42 ` David Miller [this message]
2011-10-18 10:28 ` Krishna Kumar2
2011-10-18 19:12 ` David Miller
2011-10-19 6:12 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019.194205.2298875957485608359.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=eric.dumazet@gmail.com \
--cc=krkumar2@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).