* [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. @ 2011-10-18 19:59 Krzysztof Wilczynski 2011-10-19 9:23 ` Hans Schillström 2011-10-19 10:51 ` Simon Horman 0 siblings, 2 replies; 9+ messages in thread From: Krzysztof Wilczynski @ 2011-10-18 19:59 UTC (permalink / raw) To: Simon Horman; +Cc: Patrick McHardy, netdev This is to address the following warning during compilation time: net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_leave’: net/netfilter/ipvs/ip_vs_core.c:532: warning: unused variable ‘cs’ This variable is indeed no longer in use. Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com> --- net/netfilter/ipvs/ip_vs_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index 00ea1ad..4f7d89d 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c @@ -529,7 +529,7 @@ int ip_vs_leave(struct ip_vs_service *svc, struct sk_buff *skb, a cache_bypass connection entry */ ipvs = net_ipvs(net); if (ipvs->sysctl_cache_bypass && svc->fwmark && unicast) { - int ret, cs; + int ret; struct ip_vs_conn *cp; unsigned int flags = (svc->flags & IP_VS_SVC_F_ONEPACKET && iph.protocol == IPPROTO_UDP)? -- 1.7.7 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-18 19:59 [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function Krzysztof Wilczynski @ 2011-10-19 9:23 ` Hans Schillström 2011-10-19 10:13 ` Krzysztof Wilczynski 2011-10-19 10:51 ` Simon Horman 1 sibling, 1 reply; 9+ messages in thread From: Hans Schillström @ 2011-10-19 9:23 UTC (permalink / raw) To: Krzysztof Wilczynski, Simon Horman Cc: Patrick McHardy, netdev@vger.kernel.org Hello >This is to address the following warning during compilation time: > > net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_leave’: > net/netfilter/ipvs/ip_vs_core.c:532: warning: unused variable ‘cs’ > >This variable is indeed no longer in use. > >Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com> In my code there is another fix needed as well (todays net-next) i.e. usage od cs "cs = ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd)" diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index 4f77bb1..a4ef9c6 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c @@ -530,7 +530,7 @@ int ip_vs_leave(struct ip_vs_service *svc, struct sk_buff *skb, a cache_bypass connection entry */ ipvs = net_ipvs(net); if (ipvs->sysctl_cache_bypass && svc->fwmark && unicast) { - int ret, cs; + int ret; struct ip_vs_conn *cp; unsigned int flags = (svc->flags & IP_VS_SVC_F_ONEPACKET && iph.protocol == IPPROTO_UDP)? @@ -557,7 +557,7 @@ int ip_vs_leave(struct ip_vs_service *svc, struct sk_buff *skb, ip_vs_in_stats(cp, skb); /* set state */ - cs = ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd); + ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd); /* transmit the first SYN packet */ ret = cp->packet_xmit(skb, cp, pd->pp); >--- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c >index 00ea1ad..4f7d89d 100644 >--- a/net/netfilter/ipvs/ip_vs_core.c >+++ b/net/netfilter/ipvs/ip_vs_core.c >@@ -529,7 +529,7 @@ int ip_vs_leave(struct ip_vs_service *svc, struct sk_buff *skb, > a cache_bypass connection entry */ > ipvs = net_ipvs(net); > if (ipvs->sysctl_cache_bypass && svc->fwmark && unicast) { >- int ret, cs; >+ int ret; > struct ip_vs_conn *cp; > unsigned int flags = (svc->flags & IP_VS_SVC_F_ONEPACKET && > iph.protocol == IPPROTO_UDP)? >-- >1.7.7 Regards Hans Schillstrom <hans.schillstrom@ericsson.com> ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-19 9:23 ` Hans Schillström @ 2011-10-19 10:13 ` Krzysztof Wilczynski 2011-10-19 10:37 ` Hans Schillström 0 siblings, 1 reply; 9+ messages in thread From: Krzysztof Wilczynski @ 2011-10-19 10:13 UTC (permalink / raw) To: Hans Schillström Cc: Simon Horman, Patrick McHardy, netdev@vger.kernel.org Hello, [...] > In my code there is another fix needed as well (todays net-next) > i.e. usage od cs "cs = ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd)" [...] Well spotted in terms of "net-next" branch and/or repository. In my case, I was working against "ipvs-next" using Simon's tree on github (I have made the fork when kernel.org facilities were not available at the time): https://github.com/horms/ipvs-next, and the code line you still appear to have in Dave's "net-next" (if that is the one) was amended in the following commit made against "ipvs-next": commit 833656973cde30ba067a994c4802ebab6c9557ee Author: Simon Horman <horms@verge.net.au> Date: Fri Sep 16 14:11:49 2011 +0900 ipvs: Remove unused return value of protocol state transitions Acked-by: Julian Anastasov <ja@ssi.bg> Acked-by Hans Schillstrom <hans@schillstrom.com> Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> It wasn't there when I went about cleaning unused declaration of "cs". I guess we have to make sure that everything between github (and repositories there) and kernel.org repositories like Dave's "net-next" align and holds water. Just by looking at some files, I can see that "net-next" is missing some commits. KW ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-19 10:13 ` Krzysztof Wilczynski @ 2011-10-19 10:37 ` Hans Schillström 2011-10-19 10:49 ` Simon Horman 2011-10-19 11:07 ` Pablo Neira Ayuso 0 siblings, 2 replies; 9+ messages in thread From: Hans Schillström @ 2011-10-19 10:37 UTC (permalink / raw) To: Krzysztof Wilczynski Cc: Simon Horman, Patrick McHardy, netdev@vger.kernel.org, pablo@netfilter.org >Hello, > >[...] >> In my code there is another fix needed as well (todays net-next) >> i.e. usage od cs "cs = ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd)" >[...] > >Well spotted in terms of "net-next" branch and/or repository. > >In my case, I was working against "ipvs-next" using Simon's tree on >github (I have made the fork when kernel.org facilities were not >available at the time): https://github.com/horms/ipvs-next, and the >code line you still appear to have in Dave's "net-next" (if that is >the one) was amended in the following commit made against "ipvs-next": Sorry, I didn't use that repo... (waiting for ipvs return to kernel.org) > > >commit 833656973cde30ba067a994c4802ebab6c9557ee >Author: Simon Horman <horms@verge.net.au> >Date: Fri Sep 16 14:11:49 2011 +0900 > > ipvs: Remove unused return value of protocol state transitions > > Acked-by: Julian Anastasov <ja@ssi.bg> > Acked-by Hans Schillstrom <hans@schillstrom.com> > Signed-off-by: Simon Horman <horms@verge.net.au> > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > >From what I can see Simon made a pull request and it was Acked by Pablo 28 Sep http://www.spinics.net/lists/netfilter-devel/msg19742.html I have not seen any output to Miller yet... but I might be wrong in that case > >It wasn't there when I went about cleaning unused declaration of "cs". >I guess we have to make sure that everything between github (and >repositories there) and kernel.org repositories like Dave's "net-next" >align and holds water. Just by looking at some files, I can see that >"net-next" is missing some commits. > >KW Regards Hans ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-19 10:37 ` Hans Schillström @ 2011-10-19 10:49 ` Simon Horman 2011-10-19 11:11 ` Pablo Neira Ayuso 2011-10-19 11:07 ` Pablo Neira Ayuso 1 sibling, 1 reply; 9+ messages in thread From: Simon Horman @ 2011-10-19 10:49 UTC (permalink / raw) To: Hans Schillström Cc: Krzysztof Wilczynski, Patrick McHardy, Pablo Neira Ayuso, netdev On Wed, Oct 19, 2011 at 12:37:51PM +0200, Hans Schillström wrote: > > >Hello, > > > >[...] > >> In my code there is another fix needed as well (todays net-next) > >> i.e. usage od cs "cs = ip_vs_set_state(cp, IP_VS_DIR_INPUT, skb, pd)" > >[...] > > > >Well spotted in terms of "net-next" branch and/or repository. > > > >In my case, I was working against "ipvs-next" using Simon's tree on > >github (I have made the fork when kernel.org facilities were not > >available at the time): https://github.com/horms/ipvs-next, and the > >code line you still appear to have in Dave's "net-next" (if that is > >the one) was amended in the following commit made against "ipvs-next": > > Sorry, I didn't use that repo... > (waiting for ipvs return to kernel.org) It may take a little while for me to get into the new kernel.org web of trust which needs to happen before ipvs moves back to kernel.org. > > > >commit 833656973cde30ba067a994c4802ebab6c9557ee > >Author: Simon Horman <horms@verge.net.au> > >Date: Fri Sep 16 14:11:49 2011 +0900 > > > > ipvs: Remove unused return value of protocol state transitions > > > > Acked-by: Julian Anastasov <ja@ssi.bg> > > Acked-by Hans Schillstrom <hans@schillstrom.com> > > Signed-off-by: Simon Horman <horms@verge.net.au> > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > > > > >From what I can see Simon made a pull request and it was Acked by Pablo 28 Sep > http://www.spinics.net/lists/netfilter-devel/msg19742.html > > I have not seen any output to Miller yet... > but I might be wrong in that case Yes, it seems that Pablo has picked up the change but it hasn't propagated to Dave's tree for one reason or another. > >It wasn't there when I went about cleaning unused declaration of "cs". > >I guess we have to make sure that everything between github (and > >repositories there) and kernel.org repositories like Dave's "net-next" > >align and holds water. Just by looking at some files, I can see that > >"net-next" is missing some commits. > > > >KW > > Regards > Hans ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-19 10:49 ` Simon Horman @ 2011-10-19 11:11 ` Pablo Neira Ayuso 2011-10-19 12:08 ` Simon Horman 0 siblings, 1 reply; 9+ messages in thread From: Pablo Neira Ayuso @ 2011-10-19 11:11 UTC (permalink / raw) To: Simon Horman Cc: Hans Schillström, Krzysztof Wilczynski, Patrick McHardy, netdev On Wed, Oct 19, 2011 at 07:49:57PM +0900, Simon Horman wrote: > Yes, it seems that Pablo has picked up the change but > it hasn't propagated to Dave's tree for one reason or another. I was waiting for david to take bugfixes for his net tree. This happened yesterday. Now I'll send updates for net-next. I expect to make it along today, please, be patient, they'll show up in david's net-next tree soon :-) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-19 11:11 ` Pablo Neira Ayuso @ 2011-10-19 12:08 ` Simon Horman 0 siblings, 0 replies; 9+ messages in thread From: Simon Horman @ 2011-10-19 12:08 UTC (permalink / raw) To: Pablo Neira Ayuso Cc: Hans Schillström, Krzysztof Wilczynski, Patrick McHardy, netdev On Wed, Oct 19, 2011 at 01:11:12PM +0200, Pablo Neira Ayuso wrote: > On Wed, Oct 19, 2011 at 07:49:57PM +0900, Simon Horman wrote: > > Yes, it seems that Pablo has picked up the change but > > it hasn't propagated to Dave's tree for one reason or another. > > I was waiting for david to take bugfixes for his net tree. This > happened yesterday. Now I'll send updates for net-next. > > I expect to make it along today, please, be patient, they'll show up > in david's net-next tree soon :-) Hi Pablo, thanks for the clarification. I can be patient :-) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-19 10:37 ` Hans Schillström 2011-10-19 10:49 ` Simon Horman @ 2011-10-19 11:07 ` Pablo Neira Ayuso 1 sibling, 0 replies; 9+ messages in thread From: Pablo Neira Ayuso @ 2011-10-19 11:07 UTC (permalink / raw) To: Hans Schillström Cc: Krzysztof Wilczynski, Simon Horman, Patrick McHardy, netdev@vger.kernel.org On Wed, Oct 19, 2011 at 12:37:51PM +0200, Hans Schillström wrote: > >commit 833656973cde30ba067a994c4802ebab6c9557ee > >Author: Simon Horman <horms@verge.net.au> > >Date: Fri Sep 16 14:11:49 2011 +0900 > > > > ipvs: Remove unused return value of protocol state transitions > > > > Acked-by: Julian Anastasov <ja@ssi.bg> > > Acked-by Hans Schillstrom <hans@schillstrom.com> > > Signed-off-by: Simon Horman <horms@verge.net.au> > > Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > > > > From what I can see Simon made a pull request and it was Acked by Pablo 28 Sep > http://www.spinics.net/lists/netfilter-devel/msg19742.html > > I have not seen any output to Miller yet... > but I might be wrong in that case This patch is in my nf-next tree: http://1984.lsi.us.es/git/?p=net-next/.git;a=shortlog;h=refs/heads/nf-next David just pulled from my nf tree for bugfix yesterday. I expect to send him nf-next updates by today. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function. 2011-10-18 19:59 [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function Krzysztof Wilczynski 2011-10-19 9:23 ` Hans Schillström @ 2011-10-19 10:51 ` Simon Horman 1 sibling, 0 replies; 9+ messages in thread From: Simon Horman @ 2011-10-19 10:51 UTC (permalink / raw) To: Krzysztof Wilczynski; +Cc: Patrick McHardy, netdev On Tue, Oct 18, 2011 at 08:59:49PM +0100, Krzysztof Wilczynski wrote: > This is to address the following warning during compilation time: > > net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_leave’: > net/netfilter/ipvs/ip_vs_core.c:532: warning: unused variable ‘cs’ > > This variable is indeed no longer in use. Thanks, applied to ipvs-next, currently living at git://github.com/horms/ipvs-next.git ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-10-19 12:08 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-10-18 19:59 [PATCH] ipvs: Remove unused variable "cs" from ip_vs_leave function Krzysztof Wilczynski 2011-10-19 9:23 ` Hans Schillström 2011-10-19 10:13 ` Krzysztof Wilczynski 2011-10-19 10:37 ` Hans Schillström 2011-10-19 10:49 ` Simon Horman 2011-10-19 11:11 ` Pablo Neira Ayuso 2011-10-19 12:08 ` Simon Horman 2011-10-19 11:07 ` Pablo Neira Ayuso 2011-10-19 10:51 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).