From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, daniel.turull@gmail.com,
netdev@vger.kernel.org, robert@herjulf.net, voravit@kth.se,
jens.laas@uadm.uu.se
Subject: Re: [patch] pktgen: bug when calling ndelay in x86 architectures
Date: Thu, 20 Oct 2011 16:24:44 -0400 (EDT) [thread overview]
Message-ID: <20111020.162444.559487256559727633.davem@davemloft.net> (raw)
In-Reply-To: <1318949264.2657.97.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 18 Oct 2011 16:47:44 +0200
> Le mardi 18 octobre 2011 à 15:00 +0100, Ben Hutchings a écrit :
>
>> AIUI, the reason for limits on delays is not that it's bad practice to
>> spin for so long, but that the delay calculations may overflow or
>> otherwise become inaccurate.
>
> OK, I can understand that, then a more appropriate patch would be :
I think doing the udelay/ndelay thing is the way to go for 'net' and
-stable. We can do something sophisticated with ktime et al. in
'net-next'.
Eric, could you please formally submit this patch with proper
changelog etc.?
Thanks.
next prev parent reply other threads:[~2011-10-20 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 11:08 [patch] pktgen: bug when calling ndelay in x86 architectures Daniel Turull
2011-10-18 11:56 ` Eric Dumazet
2011-10-18 14:00 ` Ben Hutchings
2011-10-18 14:47 ` Eric Dumazet
[not found] ` <4E9E9963.7090209@gmail.com>
2011-10-19 10:13 ` Eric Dumazet
2011-10-20 13:22 ` Daniel Turull
2011-10-20 13:44 ` Eric Dumazet
2011-10-20 14:26 ` Daniel Turull
2011-10-20 20:24 ` David Miller [this message]
2011-10-20 20:55 ` Eric Dumazet
2011-10-20 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020.162444.559487256559727633.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=daniel.turull@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jens.laas@uadm.uu.se \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.net \
--cc=voravit@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).