* [PATCH net-next] igb: fix a compile warning
@ 2011-10-19 8:52 roy.qing.li
2011-10-19 16:28 ` Rose, Gregory V
0 siblings, 1 reply; 3+ messages in thread
From: roy.qing.li @ 2011-10-19 8:52 UTC (permalink / raw)
To: netdev
From: RongQing Li <roy.qing.li@gmail.com>
control these three function declarations and
definitions with same macro CONFIG_PCI_IOV
drivers/net/ethernet/intel/igb/igb_main.c:165:
warning: ‘igb_vf_configure’ declared ‘static’ but never defined
drivers/net/ethernet/intel/igb/igb_main.c:166:
warning: ‘igb_find_enabled_vfs’ declared ‘static’ but never defined
drivers/net/ethernet/intel/igb/igb_main.c:167:
warning: ‘igb_check_vf_assignment’ declared ‘static’ but never defined
Signed-off-by: RongQing Li <roy.qing.li@gmail.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 837adbb..5d16cdc 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -162,9 +162,12 @@ static int igb_ndo_set_vf_bw(struct net_device *netdev, int vf, int tx_rate);
static int igb_ndo_get_vf_config(struct net_device *netdev, int vf,
struct ifla_vf_info *ivi);
static void igb_check_vf_rate_limit(struct igb_adapter *);
+
+#ifdef CONFIG_PCI_IOV
static int igb_vf_configure(struct igb_adapter *adapter, int vf);
static int igb_find_enabled_vfs(struct igb_adapter *adapter);
static int igb_check_vf_assignment(struct igb_adapter *adapter);
+#endif
#ifdef CONFIG_PM
static int igb_suspend(struct pci_dev *, pm_message_t);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] igb: fix a compile warning
2011-10-19 8:52 [PATCH net-next] igb: fix a compile warning roy.qing.li
@ 2011-10-19 16:28 ` Rose, Gregory V
2011-10-20 21:09 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Rose, Gregory V @ 2011-10-19 16:28 UTC (permalink / raw)
To: roy.qing.li@gmail.com, netdev@vger.kernel.org
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of roy.qing.li@gmail.com
> Sent: Wednesday, October 19, 2011 1:53 AM
> To: netdev@vger.kernel.org
> Subject: [PATCH net-next] igb: fix a compile warning
>
> From: RongQing Li <roy.qing.li@gmail.com>
>
> control these three function declarations and
> definitions with same macro CONFIG_PCI_IOV
>
> drivers/net/ethernet/intel/igb/igb_main.c:165:
> warning: ‘igb_vf_configure’ declared ‘static’ but never defined
> drivers/net/ethernet/intel/igb/igb_main.c:166:
> warning: ‘igb_find_enabled_vfs’ declared ‘static’ but never defined
> drivers/net/ethernet/intel/igb/igb_main.c:167:
> warning: ‘igb_check_vf_assignment’ declared ‘static’ but never defined
>
> Signed-off-by: RongQing Li <roy.qing.li@gmail.com>
Acked-by: Greg Rose <gregory.v.rose@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] igb: fix a compile warning
2011-10-19 16:28 ` Rose, Gregory V
@ 2011-10-20 21:09 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-10-20 21:09 UTC (permalink / raw)
To: gregory.v.rose; +Cc: roy.qing.li, netdev
From: "Rose, Gregory V" <gregory.v.rose@intel.com>
Date: Wed, 19 Oct 2011 09:28:54 -0700
>> -----Original Message-----
>> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
>> On Behalf Of roy.qing.li@gmail.com
>> Sent: Wednesday, October 19, 2011 1:53 AM
>> To: netdev@vger.kernel.org
>> Subject: [PATCH net-next] igb: fix a compile warning
>>
>> From: RongQing Li <roy.qing.li@gmail.com>
>>
>> control these three function declarations and
>> definitions with same macro CONFIG_PCI_IOV
>>
>> drivers/net/ethernet/intel/igb/igb_main.c:165:
>> warning: ‘igb_vf_configure’ declared ‘static’ but never defined
>> drivers/net/ethernet/intel/igb/igb_main.c:166:
>> warning: ‘igb_find_enabled_vfs’ declared ‘static’ but never defined
>> drivers/net/ethernet/intel/igb/igb_main.c:167:
>> warning: ‘igb_check_vf_assignment’ declared ‘static’ but never defined
>>
>> Signed-off-by: RongQing Li <roy.qing.li@gmail.com>
>
> Acked-by: Greg Rose <gregory.v.rose@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-20 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-19 8:52 [PATCH net-next] igb: fix a compile warning roy.qing.li
2011-10-19 16:28 ` Rose, Gregory V
2011-10-20 21:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).