From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Subject: Re: [RFC PATCH 05/17] phy_driver: Make .read_status()/.config_aneg() optional Date: Thu, 20 Oct 2011 17:14:31 -0400 Message-ID: <201110201714.36533.vapier@gentoo.org> References: <1319144425-15547-1-git-send-email-Kyle.D.Moffett@boeing.com> <1319144425-15547-6-git-send-email-Kyle.D.Moffett@boeing.com> <201110201710.17519.vapier@gentoo.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5142648.7MtJnzBNX1"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Randy Dunlap , Stephen Hemminger , "David S. Miller" , Greg Dietsche , Giuseppe Cavallaro , David Daney , Arnaud Patard , Grant Likely , Baruch Siach , Thorsten Schubert , David Decotigny , Andrew Morton , Lucas De Marchi , "Marc Kleine-Budde" , linux-doc@vger.kernel.org To: Kyle Moffett Return-path: In-Reply-To: <201110201710.17519.vapier@gentoo.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --nextPart5142648.7MtJnzBNX1 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday 20 October 2011 17:10:12 Mike Frysinger wrote: > On Thursday 20 October 2011 17:00:12 Kyle Moffett wrote: > > Approximately 90% of the PHY drivers follow the PHY layer docs and > > simply use &genphy_read_status and &genphy_config_aneg. There would > > seem to be little point in requiring them all to manually specify those > > functions. >=20 > well, it does make sense if you think about the compile vs build time > overhead. yes, your patch does make things much nicer to read, and a > little easier to maintain the source. however, it adds runtime overhead > (checking the func pointers) while the func pointer storage is unchanged > (it's now a NULL pointer instead of pointing to the genphy funcs).=20 > personally, i think the savings in runtime and smaller compiled code is > more important. so i'm going to NAK this. sorry. >=20 > > This patch makes it much easier for subsequent patches to split and > > refactor the functionality of the .config_aneg() method. > >=20 > > Signed-off-by: Kyle Moffett > > --- > >=20 > > Documentation/networking/phy.txt | 13 +++++-------- > > drivers/net/phy/bcm63xx.c | 4 ---- >=20 > hrm, what tree are you using ? this driver is not in mainline. ah, sorry, i was thinking this was u-boot since we were just having=20 conversations there. since this is Linux, and i don't have real standing in the general netdev=20 community, i can't really NAK here. but i think my comment still stands in= =20 that this patch makes things much worse than the minor code style improveme= nt. =2Dmike --nextPart5142648.7MtJnzBNX1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJOoI88AAoJEEFjO5/oN/WBMmAP/2BsSUbzSvgOTESRndxdBpqF Rw7N+gjTZQU3PDPb/iludahsqM4PGuXWFcgRreoDyTJ918NUcjum7kQ7i4zOEEJK nBxDWe8XUjbYbMbaluiKbhRfWjbulxBqCZfylVBjKc9O0GmAoxmF7bXSz77WnRdm v0582vceusJ4YKuwI3ZQoY0FC8HrBT8MBQ4yCk6W5HQVFMZyJ53Y1Cbp3bQjmWDW dxrcnDQNu1x6b5ruArO4zg7O0oMVPxIONalbORnjSHf0UmxH1Sn1N47Sl/sBckP6 IHIvwkFDK3sWSwPU2B6NB9rU3QjWeNR/Pw8uTb7RwihIbaVZlKMWp4+12O9wQCIa /2CsZkuswcN4W4plpVtivVnJ4U0zjU5Yc3W4ai28pyYlmWGPBn7xB7PQtnMRsGy8 cnR1mrlCcwpTYVPk04hGaLFm03lO68KHL7s1OZBKGrU9XQtmMXtJbzjntgdx38+w kkw4NyOccNw2Cj8reB0bTWyDzOzpmhKSLf61laKfWMWot+qCKcD9kk5O6yhCvA/e FuCaEQ1ONBUy3GKfnQ+luQ8Ufvg+1UoOS5yYY21u1cHDi/aZeIjObcMgoweFGGbI 4H0DSltANAvSUgPP3zgeqv3jZKjsE9GOOIwPuzuuqF+MiSFhKsbTFju4Djiq8rI+ wBYlO9OvzNfG9eENaBSg =igM+ -----END PGP SIGNATURE----- --nextPart5142648.7MtJnzBNX1--