From: David Miller <davem@redhat.com>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: add const qualifiers where possible
Date: Fri, 21 Oct 2011 02:55:49 -0400 (EDT) [thread overview]
Message-ID: <20111021.025549.113655582134326444.davem@redhat.com> (raw)
In-Reply-To: <1319179993.2854.63.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 Oct 2011 08:53:13 +0200
> Adding const qualifiers to pointers can ease code review, and spot some
> bugs. It might allow compiler to optimize code further.
>
> For example, is it legal to temporary write a null cksum into tcphdr
> in tcp_md5_hash_header() ? I am afraid a sniffer could catch the
> temporary null value...
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
next prev parent reply other threads:[~2011-10-21 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 6:53 [PATCH net-next] tcp: add const qualifiers where possible Eric Dumazet
2011-10-21 6:55 ` David Miller [this message]
2011-10-21 7:36 ` David Miller
2011-10-21 8:21 ` Eric Dumazet
2011-10-21 8:58 ` [PATCH V2 " Eric Dumazet
2011-10-21 9:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021.025549.113655582134326444.davem@redhat.com \
--to=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox