From: Kim Phillips <kim.phillips@freescale.com>
To: "Yan, Zheng" <zheng.z.yan@linux.intel.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<hirofumi@mail.parknet.co.jp>
Subject: Re: IPsec performance bug
Date: Fri, 21 Oct 2011 12:54:29 -0500 [thread overview]
Message-ID: <20111021125429.c84610ac.kim.phillips@freescale.com> (raw)
In-Reply-To: <CAAM7YAkxP06_=y1wg4P1JhPDWhZgRM6+wbFQRG5PFkAq8vgsTw@mail.gmail.com>
On Fri, 21 Oct 2011 16:28:30 +0800
"Yan, Zheng" <zheng.z.yan@linux.intel.com> wrote:
> On Thu, Oct 20, 2011 at 10:22 AM, Kim Phillips
> <kim.phillips@freescale.com> wrote:
> > (b) any ideas how to fix? I don't know much about routing
> > internals, but in ip_route_input_common(), if I remove the input
> > interface comparison (rth->rt_route_iif ^ iif), I get some
> > performance back, but the system becomes unstable (it's booted over
> > nfs).
>
> Looks like xfrm4_fill_dst() reset rt->rt_route_iif to 0, it makes the
> comparison (rth->rt_route_iif ^ iif) in
> ip_route_input_common() return false.
>
> Please try patch below. It improves the performance of 3.1-rc10
> kernel.
yes, thanks, ~50kpps performance is restored when applying this diff
to current net-next.
> (I'm not sure the patch is harmless)
the system appears to be more stable, but this is still concerning.
Kim
prev parent reply other threads:[~2011-10-21 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 2:22 IPsec performance bug Kim Phillips
2011-10-21 8:28 ` Yan, Zheng
2011-10-21 8:49 ` Eric Dumazet
2011-10-21 9:02 ` Yan, Zheng
2011-10-21 17:54 ` Kim Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021125429.c84610ac.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=davem@davemloft.net \
--cc=hirofumi@mail.parknet.co.jp \
--cc=netdev@vger.kernel.org \
--cc=zheng.z.yan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).