From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: maze@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: add sysctl allow_so_priority for SO_PRIORITY setsockopt
Date: Sat, 22 Oct 2011 00:04:06 -0400 (EDT) [thread overview]
Message-ID: <20111022.000406.350185785547409199.davem@davemloft.net> (raw)
In-Reply-To: <1319235725-3046-1-git-send-email-zenczykowski@gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Fri, 21 Oct 2011 15:22:05 -0700
> From: Maciej Żenczykowski <maze@google.com>
>
> This change adds a sysctl (/proc/sys/net/core/allow_so_priority)
> with a default of true (1), as such it does not change the default
> behaviour of the Linux kernel.
>
> This sysctl can be set to false (0), this will result in non
> CAP_NET_ADMIN processes being unable to set SO_PRIORITY socket
> option.
>
> This is desireable if we want to rely on socket/skb priorities
> being inferred from TOS/TCLASS bits.
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
The socket layer is not the place to enforce this.
The ingress into your MPLS/RSVP cloud that actually provides the
quality of service is where you control and mangle the TOS as needed.
Sorry, I'm not applying anything like this. Any machine on your
network can spit out any TOS it wants, and if you have control over
the apps change it's behavior there. If you don't have control over
the apps then filter and mangle.
next prev parent reply other threads:[~2011-10-22 4:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 22:22 [PATCH] net: add sysctl allow_so_priority for SO_PRIORITY setsockopt Maciej Żenczykowski
2011-10-22 4:04 ` David Miller [this message]
2011-10-22 6:49 ` Maciej Żenczykowski
2011-10-22 6:58 ` David Miller
2011-10-22 8:27 ` Maciej Żenczykowski
2011-10-22 8:40 ` David Miller
2011-10-22 9:01 ` David Täht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111022.000406.350185785547409199.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).