From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: add sysctl allow_so_priority for SO_PRIORITY setsockopt
Date: Sat, 22 Oct 2011 02:58:36 -0400 (EDT) [thread overview]
Message-ID: <20111022.025836.1306779710775525629.davem@davemloft.net> (raw)
In-Reply-To: <CAHo-OoxtAmzPjr4R7jQOk9GGQo7i-qVmoaY8vTYDQDj1HXsPNA@mail.gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Fri, 21 Oct 2011 23:49:00 -0700
> However, processes can also manually override the sk_priority by calling
> SO_PRIORITY directly, at which point their IP_TOS and SO_PRIORITY no
> longer match.
>
> This patch allows you to disable this ability.
I also don't see why we'd want to allow disabling this either.
I really hate these patches that offer ways to disable things
that normally work, and thus break apps when the non-default
is selected.
I kind of have a feeling the kind of situation you're trying to
account for, you have some cloud where people run random stuff
that you don't control.
But you didn't specify this, and we just have to guess. Why don't you
describe the specific situation where you want to modify this setting?
Please do this instead of just talking about what the side effects are
inside of the kernel. That's much less interesting when it comes to
patches like this.
next prev parent reply other threads:[~2011-10-22 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 22:22 [PATCH] net: add sysctl allow_so_priority for SO_PRIORITY setsockopt Maciej Żenczykowski
2011-10-22 4:04 ` David Miller
2011-10-22 6:49 ` Maciej Żenczykowski
2011-10-22 6:58 ` David Miller [this message]
2011-10-22 8:27 ` Maciej Żenczykowski
2011-10-22 8:40 ` David Miller
2011-10-22 9:01 ` David Täht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111022.025836.1306779710775525629.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).