From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, muralira@google.com, ak@linux.intel.com,
hidden@balabit.hu
Subject: Re: [PATCH net-next] ipv4: tcp: fix TOS value in ACK messages sent from TIME_WAIT
Date: Mon, 24 Oct 2011 03:06:32 -0400 (EDT) [thread overview]
Message-ID: <20111024.030632.1448353383063978213.davem@davemloft.net> (raw)
In-Reply-To: <1319192965.2338.25.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 Oct 2011 12:29:25 +0200
> There is a long standing bug in linux tcp stack, about ACK messages sent
> on behalf of TIME_WAIT sockets.
>
> In the IP header of the ACK message, we choose to reflect TOS field of
> incoming message, and this might break some setups.
>
> Example of things that were broken :
> - Routing using TOS as a selector
> - Firewalls
> - Trafic classification / shaping
>
> We now remember in timewait structure the inet tos field and use it in
> ACK generation, and route lookup.
>
> Notes :
> - We still reflect incoming TOS in RST messages.
> - We could extend MuraliRaja Muniraju patch to report TOS value in
> netlink messages for TIME_WAIT sockets.
> - A patch is needed for IPv6
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks a lot Eric.
next prev parent reply other threads:[~2011-10-24 7:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111010145206.6f7e9ee2@nehalam.linuxnetplumber.net>
2011-10-12 1:28 ` [PATCH v3] net-netlink: Add a new attribute to expose TOS values via netlink Muraliraja Muniraju
2011-10-12 2:48 ` Eric Dumazet
2011-10-12 4:16 ` MuraliRaja Muniraju
2011-10-12 4:31 ` Eric Dumazet
2011-10-12 19:00 ` MuraliRaja Muniraju
2011-10-21 10:29 ` [PATCH net-next] ipv4: tcp: fix TOS value in ACK messages sent from TIME_WAIT Eric Dumazet
2011-10-24 7:06 ` David Miller [this message]
2011-10-12 15:52 ` [PATCH v3] net-netlink: Add a new attribute to expose TOS values via netlink Stephen Hemminger
2011-10-12 19:00 ` [PATCH v4] " Muraliraja Muniraju
2011-10-12 19:08 ` Stephen Hemminger
2011-10-12 19:15 ` Eric Dumazet
2011-10-12 23:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024.030632.1448353383063978213.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=hidden@balabit.hu \
--cc=muralira@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).