From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: zenczykowski@gmail.com, fbl@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: make bonding slaves honour master's skb->priority
Date: Tue, 25 Oct 2011 19:22:46 -0400 (EDT) [thread overview]
Message-ID: <20111025.192246.402731945970959971.davem@davemloft.net> (raw)
In-Reply-To: <7147.1319561135@death>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Tue, 25 Oct 2011 09:45:35 -0700
> Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>
>>> I tripped on it few times and never understood why we
>>> were fixing the priority at this point.
>>> thanks,
>>
>>It looks like ancient code, going all the way back to something like
>>Linux 2.4.14 (if I recall my git blame session correctly).
>>I can't think of a good reason for this...
>
> I believe this line goes back to the beginning, prior to git or
> bk. The skb->priority probably meant something different than it does
> today.
>
> In any event, I'm fine with the code change. There's still no
> actual log message, but if Davem is ok with that I'm ok with it, given
> the trivial nature of the change.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-10-25 23:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 4:41 [PATCH] net: make bonding slaves honour master's skb->priority Maciej Żenczykowski
2011-10-25 4:58 ` Jay Vosburgh
2011-10-25 4:58 ` David Miller
2011-10-25 5:02 ` Maciej Żenczykowski
2011-10-25 5:04 ` Maciej Żenczykowski
2011-10-25 13:08 ` Flavio Leitner
2011-10-25 16:25 ` Maciej Żenczykowski
2011-10-25 16:45 ` Jay Vosburgh
2011-10-25 23:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025.192246.402731945970959971.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).