From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support Date: Thu, 27 Oct 2011 23:42:41 +0200 Message-ID: <20111027214241.GA11534@opensource.wolfsonmicro.com> References: <1319719691-15799-1-git-send-email-linus.walleij@stericsson.com> <20111027154638.GA16946@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Walleij , netdev@vger.kernel.org, Steve Glendinning , Mathieu Poirer , Robert Marklund , Paul Mundt , linux-sh@vger.kernel.org, Sascha Hauer , Tony Lindgren , linux-omap@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, Linus Walleij To: Mike Frysinger Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Oct 27, 2011 at 10:59:14PM +0200, Mike Frysinger wrote: > i saw that !CONFIG_REGULATOR works great. my concern is that these > boards don't define any regulators for smsc resources, so if > CONFIG_REGULATOR is enabled to test out unrelated daughter cards, i > don't want the network driver suddenly failing. Linus' comments > suggest that this is what would happen unless each board file has its > smsc platform resources extended. maybe i misunderstood what he was saying ? That's the case that's handled by CONFIG_REGULATOR_DUMMY - if the lookup fails the core will provide a virtual regulator to the consumer. If you're running a setup like that you probably want to enable dummy regulators anyway.