From: David Miller <davem@davemloft.net>
To: dbaluta@ixiacom.com
Cc: eric.dumazet@gmail.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
luto@amacapital.net, rick.jones2@hp.com
Subject: Re: [RFC v2] tcp: Export TCP Delayed ACK parameters to user
Date: Fri, 28 Oct 2011 18:31:07 -0400 (EDT) [thread overview]
Message-ID: <20111028.183107.2091450715774357523.davem@davemloft.net> (raw)
In-Reply-To: <CAEnQRZCxSPb8NRceB+tfdZnkN=K-jGbdmXDgNwEhZFYAWGmvAg@mail.gmail.com>
From: Daniel Baluta <dbaluta@ixiacom.com>
Date: Sat, 29 Oct 2011 00:35:24 +0300
> On Sat, Oct 29, 2011 at 12:19 AM, David Miller <davem@davemloft.net> wrote:
>> From: Daniel Baluta <dbaluta@ixiacom.com>
>> Date: Sat, 29 Oct 2011 00:14:03 +0300
>>
>>> +static inline int tcp_delack_thresh(const struct sock *sk)
>>> +{
>>> + return inet_csk(sk)->icsk_ack.rcv_mss * sysctl_tcp_delack_segs;
>>> +}
>>> +
>>
>> Please turn this into a shift or something, you're adding a multiply
>> into a core code path.
>
> Is there any generic API to do this? Default case is not
> affected since tcp_delack_segs is 1.
I'm saying make the tunable a shift count instead of something to
multiply against.
next prev parent reply other threads:[~2011-10-28 22:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 23:07 [RFC] tcp: Export TCP Delayed ACK parameters to user Daniel Baluta
2011-10-28 0:01 ` Eric Dumazet
2011-10-28 8:01 ` Daniel Baluta
2011-10-28 8:44 ` Eric Dumazet
2011-10-28 16:38 ` Rick Jones
2011-10-28 21:14 ` [RFC v2] " Daniel Baluta
2011-10-28 21:19 ` David Miller
2011-10-28 21:35 ` Daniel Baluta
2011-10-28 22:31 ` David Miller [this message]
2011-10-28 22:40 ` Rick Jones
2011-10-29 2:24 ` David Miller
2011-10-29 12:32 ` Daniel Baluta
2011-10-30 4:13 ` David Miller
2011-10-31 18:10 ` Rick Jones
2011-10-31 20:02 ` Daniel Baluta
2011-10-31 21:29 ` Rick Jones
2011-10-28 21:53 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028.183107.2091450715774357523.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).