From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: pull request: batman-adv 2011-10-29 Date: Sun, 30 Oct 2011 03:07:45 -0400 (EDT) Message-ID: <20111030.030745.1245988853394270780.davem@davemloft.net> References: <1319875606-7794-1-git-send-email-lindner_marek@yahoo.de> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org, stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org To: lindner_marek-LWAfsSFWpa4@public.gmane.org Return-path: In-Reply-To: <1319875606-7794-1-git-send-email-lindner_marek-LWAfsSFWpa4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org From: Marek Lindner Date: Sat, 29 Oct 2011 10:06:43 +0200 > git://git.open-mesh.org/linux-merge.git batman-adv/maint Pulled, but long term you should shore up your datastructures to handle that issue in patch #3. Make a common header: struct tt_entry_common { u8 addr[ETH_ALEN]; struct hlist_node hash_entry; }; Then use that at the beginning of both structures: struct tt_local_entry { struct tt_entry_common common; unsigned long last_seen; ... }; struct tt_global_entry { struct tt_entry_comomn common; struct orig_node *orig_node; ... }; And &p->common is what gets passed into tt_response_fill_table().