From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: eric.dumazet@gmail.com, john.r.fastabend@intel.com,
jesse@nicira.com, hans.schillstrom@ericsson.com,
mbizon@freebox.fr, netdev@vger.kernel.org, fubar@us.ibm.com
Subject: Re: [PATCH v2] vlan: allow nested vlan_do_receive()
Date: Sun, 30 Oct 2011 04:44:03 -0400 (EDT) [thread overview]
Message-ID: <20111030.044403.1905289523670344598.davem@davemloft.net> (raw)
In-Reply-To: <20111030083811.GA2059@minipsycho.orion>
From: Jiri Pirko <jpirko@redhat.com>
Date: Sun, 30 Oct 2011 09:38:12 +0100
> Sat, Oct 29, 2011 at 06:28:40PM CEST, jpirko@redhat.com wrote:
>>Sat, Oct 29, 2011 at 06:13:39PM CEST, eric.dumazet@gmail.com wrote:
>>>commit 2425717b27eb (net: allow vlan traffic to be received under bond)
>>>broke ARP processing on vlan on top of bonding.
...
>>>Packet is dropped in arp_rcv() because its pkt_type was set to
>>>PACKET_OTHERHOST in the first vlan_do_receive() call, since no eth0.103
>>>exists.
>>>
>>>We really need to change pkt_type only if no more rx_handler is about to
>>>be called for the packet.
>>>
>>>Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>>>---
>>>V2 : change the vlan_do_receive() added argument to be a boolean
...
> Reviewed-by: Jiri Pirko <jpirko@redhat.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2011-10-30 8:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 19:16 [net-next PATCH] net: allow vlan traffic to be received under bond John Fastabend
2011-10-10 22:37 ` Jiri Pirko
2011-10-11 2:07 ` John Fastabend
2011-10-11 2:43 ` Jesse Gross
2011-10-11 11:08 ` Hans Schillstrom
2011-10-11 13:13 ` John Fastabend
2011-10-13 13:09 ` Hans Schillström
2011-10-11 13:16 ` John Fastabend
2011-10-11 10:57 ` Jiri Pirko
2011-10-13 15:04 ` Maxime Bizon
2011-10-13 15:38 ` Jiri Pirko
2011-10-13 15:48 ` Maxime Bizon
2011-10-13 15:59 ` Hans Schillström
2011-10-13 17:42 ` John Fastabend
2011-10-13 18:23 ` Hans Schillström
2011-10-14 0:22 ` Jesse Gross
2011-10-19 3:47 ` David Miller
2011-10-28 10:00 ` Eric Dumazet
2011-10-28 11:06 ` Eric Dumazet
2011-10-29 2:20 ` John Fastabend
2011-10-29 10:22 ` Eric Dumazet
2011-10-29 14:59 ` Jiri Pirko
2011-10-29 16:00 ` Eric Dumazet
2011-10-29 16:13 ` [PATCH v2] vlan: allow nested vlan_do_receive() Eric Dumazet
2011-10-29 16:28 ` Jiri Pirko
2011-10-30 8:38 ` Jiri Pirko
2011-10-30 8:44 ` David Miller [this message]
2011-10-30 8:44 ` Eric Dumazet
2011-10-29 16:16 ` [net-next PATCH] net: allow vlan traffic to be received under bond Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111030.044403.1905289523670344598.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=hans.schillstrom@ericsson.com \
--cc=jesse@nicira.com \
--cc=john.r.fastabend@intel.com \
--cc=jpirko@redhat.com \
--cc=mbizon@freebox.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).