From: Mike Frysinger <vapier@gentoo.org>
To: Robert Marklund <robert.marklund@stericsson.com>
Cc: netdev@vger.kernel.org,
Steve Glendinning <steve.glendinning@smsc.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Paul Mundt <lethal@linux-sh.org>,
linux-sh@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 2/2 v4] net/smsc911x: Add regulator support
Date: Mon, 31 Oct 2011 14:21:15 -0400 [thread overview]
Message-ID: <201110311421.18653.vapier@gentoo.org> (raw)
In-Reply-To: <1320064719-14449-1-git-send-email-robert.marklund@stericsson.com>
[-- Attachment #1: Type: Text/Plain, Size: 437 bytes --]
On Monday 31 October 2011 08:38:39 Robert Marklund wrote:
> ChangeLog v3->v4:
> - Remove dual prints and old comment on Mike's request.
> - Split the request_free fucntion on Mike and Sascha request.
would be nice if the enable/disable were split as well ...
> iounmap(pdata->ioaddr);
>
> + (void)smsc911x_enable_disable_resources(pdev, false);
i don't think the (void) cast is necessary
otherwise looks fine
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-10-31 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 12:38 [PATCH 2/2 v4] net/smsc911x: Add regulator support Robert Marklund
2011-10-31 18:21 ` Mike Frysinger [this message]
2011-11-16 12:59 ` Robert MARKLUND
2011-11-17 5:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110311421.18653.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robert.marklund@stericsson.com \
--cc=s.hauer@pengutronix.de \
--cc=steve.glendinning@smsc.com \
--cc=tony@atomide.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).