From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr()
Date: Tue, 01 Nov 2011 05:06:36 -0400 (EDT) [thread overview]
Message-ID: <20111101.050636.2188753893784711943.davem@davemloft.net> (raw)
In-Reply-To: <CAJFZqHwBwnNPBnPYqyUR8NU2LnagJtBEnvkzRL9TqrdQEqfhXA@mail.gmail.com>
From: RongQing Li <roy.qing.li@gmail.com>
Date: Tue, 1 Nov 2011 17:05:19 +0800
> 2011/11/1 David Miller <davem@davemloft.net>:
>> From: RongQing Li <roy.qing.li@gmail.com>
>> Date: Tue, 1 Nov 2011 16:33:49 +0800
>>
>>> Yes, But I think the code readable is not good,
>>
>> It is wasteful to add multiple BH disables and RCU memory
>> barriers in code paths where it is not necessary.
>>
>> Your patch fixes no real bug, and adds a regression.
>>
>
> hlist_for_each_entry_rcu_bh() does not disable BH,
> it only check If BH is disabled.
>
> These codes is different from normal RCU convention.
But adding _rcu does add memory barriers.
next prev parent reply other threads:[~2011-11-01 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 5:30 [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr() roy.qing.li
2011-11-01 7:53 ` David Miller
2011-11-01 8:33 ` RongQing Li
2011-11-01 8:39 ` David Miller
2011-11-01 9:05 ` RongQing Li
2011-11-01 9:06 ` David Miller [this message]
2011-11-01 9:17 ` RongQing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101.050636.2188753893784711943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox