From: David Miller <davem@davemloft.net>
To: matthijs@stdin.nl
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] vlan: Don't propagate flag changes on down interfaces.
Date: Tue, 01 Nov 2011 17:51:13 -0400 (EDT) [thread overview]
Message-ID: <20111101.175113.2141024983069963090.davem@davemloft.net> (raw)
In-Reply-To: <1320072793-16490-1-git-send-email-matthijs@stdin.nl>
From: Matthijs Kooijman <matthijs@stdin.nl>
Date: Mon, 31 Oct 2011 15:53:13 +0100
> When (de)configuring a vlan interface, the IFF_ALLMULTI ans IFF_PROMISC
> flags are cleared or set on the underlying interface. So, if these flags
> are changed on a vlan interface that is not up, the flags underlying
> interface might be set or cleared twice.
>
> Only propagating flag changes when a device is up makes sure this does
> not happen. It also makes sure that an underlying device is not set to
> promiscuous or allmulti mode for a vlan device that is down.
>
> Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
Applied, thanks.
prev parent reply other threads:[~2011-11-01 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 13:44 dev->promiscuity can become negative in specific bridge + vlan configuration Matthijs Kooijman
2011-10-31 14:53 ` [PATCH] vlan: Don't propagate flag changes on down interfaces Matthijs Kooijman
2011-11-01 21:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101.175113.2141024983069963090.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=matthijs@stdin.nl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).