From: David Miller <davem@davemloft.net>
To: Joakim.Tjernlund@transmode.se
Cc: avorontsov@ru.mvista.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ucc_geth, increase no. of HW RX descriptors
Date: Wed, 02 Nov 2011 00:56:50 -0400 (EDT) [thread overview]
Message-ID: <20111102.005650.1042174729471815202.davem@davemloft.net> (raw)
In-Reply-To: <1319548630-6561-1-git-send-email-Joakim.Tjernlund@transmode.se>
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Tue, 25 Oct 2011 15:17:10 +0200
> In a busy network we see ucc_geth is dropping RX pkgs every now
> and then. Increase the first RX queues HW descriptors from
> 16 to 32 to deal with this.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
1) This patch doesn't apply, because in the current tree this
dirver lives under drivers/net/ethernet/freescale/ not
drivers/net
2) Why not increase RX_BD_RING_LEN and thus all the ring sizes,
is there a special reason only the first ring's size should
be increased?
Because the way you've made this change is confusing, someone
will see RX_BD_RING_LEN's definition and believe that this is
the size of the primary ring unless they happen to notice
how .bdRingLenRx is initialized in this special way.
Thus, this patch needs changes before it can even be considered
for inclusion.
prev parent reply other threads:[~2011-11-02 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 13:17 [PATCH] net: ucc_geth, increase no. of HW RX descriptors Joakim Tjernlund
2011-11-02 4:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102.005650.1042174729471815202.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joakim.Tjernlund@transmode.se \
--cc=avorontsov@ru.mvista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox