Re: [PATCH] r8169: Fix WOL in power down case

[Francois Romieu <romieu@fr.zoreil.com>]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

(Stefan, please keep the Cc:)

Stefan Becker <chemobejk@gmail.com> :
> On Thu, Nov 3, 2011 at 1:08 AM, Francois Romieu <romieu@fr.zoreil.com>wrote:
> > Stefan Becker <chemobejk@gmail.com> :
[...]
> > Plain power down, not suspend/resume ?
> 
> Yes, the system executes "shutdown -h now" (S5?) after arming the watchdog
> that executes the etherwake command at the appointed time.

Thanks for the clarification.

[...]
> I've installed the previously working kernel from F15. Luckily it works
> with the Fedora 16 user space. With that kernel WoL works again.
> 
> I can't check right now, but it should be
> 
>    kernel-2.6.40.6.-0.fc15.i686.rpm<http://koji.fedoraproject.org/koji/buildinfo?buildID=266719>

Ok.

Can you build the attached driver with your 3.1.x Fedora kernel ?

The diff is attached as well if the lack of gpg signature makes you nervous.

If the patch works, the regression almost surely dates back to
d4ed95d796e5126bba51466dc07e287cebc8bd19.

-- 
Ueimor

[-- Attachment #2: makefile_and_r8169.tgz --]
[-- Type: application/x-gzip, Size: 32425 bytes --]

[-- Attachment #3: r8169-more-rxconfig-bits.patch --]
[-- Type: text/plain, Size: 489 bytes --]

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 6d657ca..1fa2e80 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3321,6 +3321,10 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)
 	void __iomem *ioaddr = tp->mmio_addr;
 
 	switch (tp->mac_version) {
+	case RTL_GIGA_MAC_VER_19:
+	case RTL_GIGA_MAC_VER_20:
+	case RTL_GIGA_MAC_VER_21:
+	case RTL_GIGA_MAC_VER_22:
 	case RTL_GIGA_MAC_VER_29:
 	case RTL_GIGA_MAC_VER_30:
 	case RTL_GIGA_MAC_VER_32: