From: Richard Cochran <richardcochran@gmail.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Oliver Neukum <oneukum@suse.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"devel@openvz.org" <devel@openvz.org>,
Michael Riesch <michael@riesch.at>
Subject: Re: [PATCH] usbnet: fix oops in usbnet_start_xmit
Date: Mon, 7 Nov 2011 15:42:04 +0100 [thread overview]
Message-ID: <20111107144204.GA344@cherladcori01> (raw)
In-Reply-To: <4EB7E5A2.2070407@openvz.org>
On Mon, Nov 07, 2011 at 06:05:22PM +0400, Konstantin Khlebnikov wrote:
> Richard Cochran wrote:
> >On Sun, Nov 06, 2011 at 10:33:37PM +0300, Konstantin Khlebnikov wrote:
> >>This patch fixes the bug added in commit v3.1-rc7-1055-gf9b491e
> >>SKB can be NULL at this point, at least for cdc-ncm.
> >
> >What? You mean .ndo_start_xmit is called with skb NULL?
>
> no. cdc_ncm call usbnet_start_xmit with NULL skb from timer handler
> and tx_fixup hook pickup skb from internal context. yeah, it really messy.
You said it.
Can you please submit the fix suggested by Michael and myself?
Thanks,
Richard
next prev parent reply other threads:[~2011-11-07 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 19:33 [PATCH] usbnet: fix oops in usbnet_start_xmit Konstantin Khlebnikov
2011-11-07 13:29 ` Michael Riesch
2011-11-07 13:33 ` Richard Cochran
2011-11-07 14:05 ` Konstantin Khlebnikov
2011-11-07 14:42 ` Richard Cochran [this message]
2011-11-07 15:54 ` [PATCH v2] " Konstantin Khlebnikov
2011-11-07 17:39 ` Richard Cochran
2011-11-07 18:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107144204.GA344@cherladcori01 \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=khlebnikov@openvz.org \
--cc=michael@riesch.at \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).