From: Flavio Leitner <fbl@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] route: fix ICMP secure_redirects
Date: Mon, 7 Nov 2011 17:05:17 -0200 [thread overview]
Message-ID: <20111107170517.6acb1f87@asterix.rh> (raw)
In-Reply-To: <20111107.133541.808346933690781560.davem@davemloft.net>
On Mon, 07 Nov 2011 13:35:41 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Flavio Leitner <fbl@redhat.com>
> Date: Mon, 7 Nov 2011 13:41:45 -0200
>
> > It should accept ICMP redirects from any host and not
> > just from gateways when secure_redirects is disabled.
> >
> > Signed-off-by: Flavio Leitner <fbl@redhat.com>
>
> This is changing the default behavior, and could break things for
> people.
>
> We have sort-of discussed this already, and agreed that the tests
> made in this code before my inetpeer reworking had to be reinstated
> exactly as it was.
Right, so I cannot change either values 0 or 1 then. For some
reason I thought I couldn't change only the default behavior.
I will think on something else then.
thanks,
fbl
next prev parent reply other threads:[~2011-11-07 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 15:41 [PATCH] route: fix ICMP secure_redirects Flavio Leitner
2011-11-07 18:35 ` David Miller
2011-11-07 19:05 ` Flavio Leitner [this message]
2011-11-08 0:03 ` [PATCH] route: add more relaxed option for secure_redirects Flavio Leitner
2011-11-12 1:33 ` David Miller
2011-11-16 20:46 ` Flavio Leitner
2011-11-16 22:02 ` David Miller
2011-11-16 23:17 ` Flavio Leitner
2011-11-17 1:40 ` Flavio Leitner
2011-11-17 1:41 ` David Miller
2011-11-17 21:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107170517.6acb1f87@asterix.rh \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).