Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ne@erfurth.eu
Cc: netdev@vger.kernel.org, phil@nwl.cc, stable@vger.kernel.org,
	steve.glendinning@smsc.com
Subject: Re: [PATCH 1/1] [SMSC75xx] Fix incorrect usage of NET_IP_ALIGN
Date: Tue, 08 Nov 2011 12:37:42 -0500 (EST)	[thread overview]
Message-ID: <20111108.123742.107320764431852874.davem@davemloft.net> (raw)
In-Reply-To: <1320773440-30122-1-git-send-email-ne@erfurth.eu>

From: Nico Erfurth <ne@erfurth.eu>
Date: Tue,  8 Nov 2011 18:30:40 +0100

> The driver used NET_IP_ALIGN to remove some additional padding inside of
> the rx_fixup function. On many architectures NET_IP_ALIGN defaults to 2
> which removed the correct amount of bytes.
> 
> On MCORE2-machines commit ea812ca1b06113597adcd8e70c0f84a413d97544
> introduces a change which sets NET_IP_ALIGN to 0 by default. Which
> triggered the bug on these machines.
> 
> This fix introduces a new RXW_PADDING define and uses this instead of
> NET_IP_ALIGN. The name was taken from the original SMSC7500 driver which
> is provided by SMSC.
> 
> Signed-off-by: Nico Erfurth <ne@erfurth.eu>
> Tested-by: Phil Sutter <phil@nwl.cc>

Applied.

      reply	other threads:[~2011-11-08 17:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 17:30 [PATCH 1/1] [SMSC75xx] Fix incorrect usage of NET_IP_ALIGN Nico Erfurth
2011-11-08 17:37 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111108.123742.107320764431852874.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ne@erfurth.eu \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=stable@vger.kernel.org \
    --cc=steve.glendinning@smsc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox