From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: spiked.yar@gmail.com, netdev@vger.kernel.org
Subject: Re: PROBLEM: pppol2tp over pppoe NULL pointer dereference
Date: Tue, 08 Nov 2011 14:00:00 -0500 (EST) [thread overview]
Message-ID: <20111108.140000.543570939575214751.davem@davemloft.net> (raw)
In-Reply-To: <1320478829.16609.15.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 05 Nov 2011 08:40:29 +0100
> Le vendredi 04 novembre 2011 à 22:28 -0400, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Wed, 02 Nov 2011 00:58:13 +0100
>>
>> > Please try following patch, thanks !
>> >
>> > [PATCH] l2tp: handle fragmented skbs in receive path
>> >
>> > Modern drivers provide skb with fragments, and L2TP doesnt properly
>> > handles them.
>> >
>> > Some bad frames can also trigger panics because of insufficent checks.
>> >
>> > Reported-by: Misha Labjuk <spiked.yar@gmail.com>
>> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> I'm still waiting for testing results of this patch.
>
> Of course.
>
> If you prefer, I can submit a smaller patch for the obvious bug first,
> and I can respin the thing when net-next reopens.
>
> [PATCH] l2tp: fix l2tp_udp_recv_core()
>
> pskb_may_pull() can change skb->data, so we have to load ptr/optr at the
> right place.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Yes, this is easier to digest right now.
Applied.
next prev parent reply other threads:[~2011-11-08 19:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 22:00 PROBLEM: pppol2tp over pppoe NULL pointer dereference Misha Labjuk
2011-11-01 22:35 ` Eric Dumazet
2011-11-02 5:04 ` Misha Labjuk
2011-11-02 7:07 ` Eric Dumazet
2011-11-02 15:54 ` Jorge Boncompte [DTI2]
2011-11-02 22:35 ` Misha Labjuk
2011-11-02 22:53 ` [PATCH] l2tp: fix l2tp_recv_dequeue() Eric Dumazet
2011-11-03 6:50 ` Eric Dumazet
2011-11-03 8:47 ` PROBLEM: pppol2tp over pppoe NULL pointer dereference Eric Dumazet
2011-11-03 22:02 ` David Miller
2011-11-01 22:56 ` [PATCH] udp: fix a race in encap_rcv handling Eric Dumazet
2011-11-02 4:51 ` David Miller
2011-11-01 23:58 ` PROBLEM: pppol2tp over pppoe NULL pointer dereference Eric Dumazet
2011-11-05 2:28 ` David Miller
2011-11-05 7:40 ` Eric Dumazet
2011-11-08 19:00 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-18 15:35 Окунев Дмитрий Юрьевич
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108.140000.543570939575214751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=spiked.yar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).