From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: khlebnikov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: usbnet: fix oops in usbnet_start_xmit
Date: Wed, 9 Nov 2011 10:34:59 +0300 [thread overview]
Message-ID: <20111109073459.GA14409@elgon.mountain> (raw)
Hello Konstantin Khlebnikov,
This is a semi-automatic email about new static checker warnings.
The patch 23ba07991dad: "usbnet: fix oops in usbnet_start_xmit" from
Nov 7, 2011, leads to the following Smatch complaint:
drivers/net/usb/usbnet.c +1077 usbnet_start_xmit()
error: we previously assumed 'skb' could be null (see line 1060)
drivers/net/usb/usbnet.c
1059
1060 if (skb)
^^^
check introduced here.
1061 skb_tx_timestamp(skb);
1062
1063 // some devices want funky USB-level framing, for
1064 // win32 driver (usually) and/or hardware quirks
1065 if (info->tx_fixup) {
1066 skb = info->tx_fixup (dev, skb, GFP_ATOMIC);
1067 if (!skb) {
1068 if (netif_msg_tx_err(dev)) {
1069 netif_dbg(dev, tx_err, dev->net, "can't tx_fixup skb\n");
1070 goto drop;
1071 } else {
1072 /* cdc_ncm collected packet; waits for more */
1073 goto not_drop;
1074 }
1075 }
1076 }
1077 length = skb->len;
^^^^^^^^
dereference without checking.
1078
1079 if (!(urb = usb_alloc_urb (0, GFP_ATOMIC))) {
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2011-11-09 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 7:34 Dan Carpenter [this message]
[not found] ` <20111109073459.GA14409-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-09-06 12:52 ` usbnet: fix oops in usbnet_start_xmit Dan Carpenter
2012-09-06 13:10 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109073459.GA14409@elgon.mountain \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=khlebnikov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).