From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Maris Paupe <marisp@mt.lv>, netdev@vger.kernel.org
Subject: Re: [PATCH] flow_cache_flush soft lockup with heavy ipsec traffic
Date: Wed, 9 Nov 2011 14:43:48 +0100 [thread overview]
Message-ID: <20111109134348.GD10138@secunet.com> (raw)
In-Reply-To: <1320844564.3916.4.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Wed, Nov 09, 2011 at 02:16:04PM +0100, Eric Dumazet wrote:
>
> Sorry, I dont understand your patch.
>
> BH are disabled by the spin_lock_bh() call.
>
> Once flow_cache_entry are in garbage list, nothing but garbage collector
> can access them. I see no possible deadlock. Or there is a bug somewhere
> and your patch avoid it.
>
> Whole point of using a work queue to perform garbage collect was to not
> hold BH too long (allowing sotirq to process incoming packets), so you
> basically remove what was done in commit 8e4795605d.
>
I guess this tries to address a problem that was already discussed here:
http://patchwork.ozlabs.org/patch/116457/
next prev parent reply other threads:[~2011-11-09 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 12:21 [PATCH] flow_cache_flush soft lockup with heavy ipsec traffic Maris Paupe
2011-11-09 13:16 ` Eric Dumazet
2011-11-09 13:43 ` Steffen Klassert [this message]
2011-11-09 14:41 ` Maris Paupe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109134348.GD10138@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=eric.dumazet@gmail.com \
--cc=marisp@mt.lv \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).