netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: Flavio Leitner <fbl@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
	davem@davemloft.net, eric.dumazet@gmail.com,
	bhutchings@solarflare.com, shemminger@vyatta.com,
	fubar@us.ibm.com, andy@greyhouse.net, tgraf@infradead.org,
	ebiederm@xmission.com, mirqus@gmail.com, kaber@trash.net,
	greearb@candelatech.com, jesse@nicira.com,
	benjamin.poirier@gmail.com, jzupka@redhat.com
Subject: Re: [PATCH] libteam: fix function names to include 'bond'
Date: Wed, 9 Nov 2011 23:04:25 +0100	[thread overview]
Message-ID: <20111109220423.GA2112@minipsycho> (raw)
In-Reply-To: <1320862846-6000-1-git-send-email-fbl@redhat.com>


Hi Flavio.

Thomas included these 2 functions in latest libnl upstream. Bond
versions wouldn't work because of "bond" type check.

Jirka

Wed, Nov 09, 2011 at 07:20:46PM CET, fbl@redhat.com wrote:
>Signed-off-by: Flavio Leitner <fbl@redhat.com>
>---
>
> I found those while trying to test V6 patch using latest
> libteam (commit 5e9790816606a6dd4e7f6f32c0bb0c45e5d13b31)
> and libnl-3.2.2 (last stable).
> thanks,
> fbl
>
> lib/libteam.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/libteam.c b/lib/libteam.c
>index feb13b6..e7ae6b0 100644
>--- a/lib/libteam.c
>+++ b/lib/libteam.c
>@@ -1331,7 +1331,7 @@ int team_port_add(struct team_handle *th, uint32_t port_ifindex)
> {
> 	int err;
> 
>-	err = rtnl_link_enslave_ifindex(th->nl_cli.sock, th->ifindex,
>+	err = rtnl_link_bond_enslave_ifindex(th->nl_cli.sock, th->ifindex,
> 					port_ifindex);
> 	return -nl2syserr(err);
> }
>@@ -1350,6 +1350,6 @@ int team_port_remove(struct team_handle *th, uint32_t port_ifindex)
> {
> 	int err;
> 
>-	err = rtnl_link_release_ifindex(th->nl_cli.sock, port_ifindex);
>+	err = rtnl_link_bond_release_ifindex(th->nl_cli.sock, port_ifindex);
> 	return -nl2syserr(err);
> }
>-- 
>1.7.6
>

  reply	other threads:[~2011-11-09 22:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 20:27 [patch net-next V6] net: introduce ethernet teaming device Jiri Pirko
2011-11-09 18:20 ` [PATCH] libteam: fix function names to include 'bond' Flavio Leitner
2011-11-09 22:04   ` Jiri Pirko [this message]
2011-11-09 23:23     ` Flavio Leitner
2011-11-10  6:41       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111109220423.GA2112@minipsycho \
    --to=jpirko@redhat.com \
    --cc=andy@greyhouse.net \
    --cc=benjamin.poirier@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fbl@redhat.com \
    --cc=fubar@us.ibm.com \
    --cc=greearb@candelatech.com \
    --cc=jesse@nicira.com \
    --cc=jzupka@redhat.com \
    --cc=kaber@trash.net \
    --cc=mirqus@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=tgraf@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).